Actions
Defect #30431
closedUseless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-member
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Since you cannot grant a "Delete issues" permission for Anonymous and Non-member roles, "Delete issues" column in the tracker permission table on the role page is useless. The column should be hidden like default "Reporter" role.
Files
Updated by Yuichi HARADA over 5 years ago
- File 30431.patch 30431.patch added
It was displayed "Delete issues" column in the tracker permission table on the role page because it was not confirmed the settable permissions of the role.
I attached a patch.
Updated by Go MAEDA over 5 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA about 5 years ago
- File 30431-v2.patch 30431-v2.patch added
- Target version changed from Candidate for next minor release to 4.1.0
LGTM but I propose a slight change as follows. Using &
operator is simpler and much faster than using delete_if
.
<% permissions = [:view_issues, :add_issues, :edit_issues, :add_issue_notes, :delete_issues] & setable_permissions.collect(&:name) %>
Setting the target version to 4.1.0.
Updated by Go MAEDA about 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for fixing this issue.
Actions