Project

General

Profile

Actions

Defect #31087

closed

Deleting a version silently deletes its attachments

Added by Go MAEDA almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Files
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Deleting a version which has one or more attachments unexpectedly succeeds if no issues are associated with the version.

You can reproduce the problem with the following steps:

1. Create a new version
2. Open the "Files" tab in the project menu
3. Attach a file to the version
4. Delete the version. Attached files are deleted along with the version without warning

I think Redmine should not allow deleting a version with attachments.

The problem was originally reported by Karel Pičman in #1265#note-6. He also provided a patch.


Files

31087.patch (1.03 KB) 31087.patch Takenori TAKAKI, 2019-03-26 09:44
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Description updated (diff)
Actions #2

Updated by Takenori TAKAKI almost 5 years ago

Go MAEDA wrote:

You can reproduce the problem with the following steps:

1. Create a new version
2. Open the "Files" tab in the project menu
3. Attach a file to the version
4. Delete the version. Attached files are deleted along with the version without warning

I think Redmine should not allow deleting a version with attachments.

I could reproduce this problem on my environment. I also think that Redmine should not allow deleting the version with attachments.
I made a patch that added test code to the Karel Pičman's patch.

Actions #3

Updated by Go MAEDA almost 5 years ago

  • Target version set to 3.4.10

Setting the target version to 3.4.10.

Actions #4

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Deleting a version deletes files attached to the version without warning to Fix that deleting a version silently deletes its attachments
  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

Actions #5

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Fix that deleting a version silently deletes its attachments to Deleting a version silently deletes its attachments
Actions #6

Updated by Go MAEDA almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF