Defect #32664
open
Adding an empty reply to a forum message does not show any error
Added by Go MAEDA almost 5 years ago.
Updated over 4 years ago.
Description
Steps to reproduce:
1. Open any forum topic and click "Reply"
2. Attach any file and click "Submit"
3. You will see "Successful update" message but the reply is not added. The attachment is silently discarded
Expected behavior:
"Content cannot be blank" error should be shown.
Files
Show any error message when submitting a reply. I attached a patch.
However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.
Yuichi HARADA wrote:
However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.
You are right. Thank you for pointing it out.
And I found that the behavior that showing an error is not consistent with issues. When updating issues, no error is shown even if note is empty. Its behavior is similar to forums but the only difference is the behavior when adding attachments with an empty note. In the case, attachments are added to the issue.
I think the following behavior is better for forums. It is consistent with the behavior of issues.
- Empty message without attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
- empty message with attachments: Attach the files instead of discarding them
Go MAEDA wrote:
I think the following behavior is better for forums. It is consistent with the behavior of issues.
- Empty message without attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
- empty message with attachments: Attach the files instead of discarding them
Thank you for pointing it out. I attached a patch that incorporates the above behaviors.
- Target version set to Candidate for next major release
Also available in: Atom
PDF
Updated by 
Updated by