Patch #37558
closedUpdate webdrivers to 5.0
0%
Description
Upgrade webdrivers, etc. To enable system tests can be run on ruby3 or later.
In addition, we do not load the driver for localhost when we set `SELENIUM_REMOTE_URL` to support a host without a browser (Docker environment, etc.).
Files
Updated by Go MAEDA about 2 years ago
Updated by Go MAEDA about 2 years ago
- Target version set to Candidate for next major release
Updated by Go MAEDA about 2 years ago
- Target version changed from Candidate for next major release to 5.1.0
Setting the target version to 5.1.0.
Updated by Ko Nagase about 2 years ago
I encountered webdriver issue on my M1 Mac environment recently. (At least, there was no problem at 2022-10-10(Mon).)
% bundle exec rails test:system
rails aborted!
Webdrivers::NetworkError: Net::HTTPServerException: 404 "Not Found" with https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip
From the following Japanese article, updating webdrivers >= 5.2.0 seems to be necessary,
- Japanese Qiita article: https://qiita.com/jnchito/items/ef384a39cb063b0af463
- GitHub issue: https://github.com/titusfortner/webdrivers/issues/237
so, I hope that this update will be merged before 5.1.0 for system test.
Updated by Takashi Kato about 1 year ago
As per the following pull request, selenium-webdriver 4.11 or later does not require the webdriver description in the Gemfile.
The fixed patch is available here.
Updated by Marius BĂLTEANU about 1 year ago
Applying this patch on Ruby 3.1, I receive the following error:
rake aborted! LoadError: cannot load such file -- webdrivers/chromedriver /builds/redmine-org/redmine/vendor/ruby/3.1.0/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38:in `require' /builds/redmine-org/redmine/vendor/ruby/3.1.0/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38:in `require'
On Ruby 3.0, the system tests are running. Do you have any ideea?
Updated by Takashi Kato about 1 year ago
This is my mistake.
I did not notice this because I was testing with SELENIUM_REMOTE_URL set at hand.
I fixed the part of application_system_test_case.rb that calls webdriver.
Updated by Marius BĂLTEANU about 1 year ago
- Status changed from New to Closed
- Assignee set to Marius BĂLTEANU
Committed, thanks!