Patch #4069

Alternate theme lacking right border if no sidebar present

Added by Felix Schäfer about 8 years ago. Updated about 8 years ago.

Status:ClosedStart date:2009-10-21
Priority:LowDue date:
Assignee:Eric Davis% Done:

0%

Category:UI
Target version:0.9.0

Description

Pages without a sidebar lack the right border on the content div with the alternate style. It's enough to specialise the #content style in the alternate css with a #main.nosidebar #content to get it back. (test on Safari 4, redmine r2902).

git diff:

--- a/public/themes/alternate/stylesheets/application.css
+++ b/public/themes/alternate/stylesheets/application.css
@@ -3,7 +3,7 @@
 body, #wrapper { background-color:#EEEEEE; }
 #header, #top-menu { margin: 0px 10px 0px 11px; }
 #main { background: #EEEEEE; margin: 8px 10px 0px 10px; }
-#content { background: #fff; border-right: 1px solid #bbb; border-bottom: 1px solid #bbb; border-left: 1px solid #d7d7d7; border-top: 1px solid #d7d7d7; }
+#content, #main.nosidebar #content { background: #fff; border-right: 1px solid #bbb; border-bottom: 1px solid #bbb; border-left: 1px solid #d7d7d7; border-
 #footer { background-color:#EEEEEE; border: 0px; }

 /* Headers */

Associated revisions

Revision 3069
Added by Jean-Philippe Lang about 8 years ago

Fixed: Alternate theme lacking right border if no sidebar present (#4069).

History

#1 Updated by Felix Schäfer about 8 years ago

  • Assignee set to Eric Davis

Just wanted to get this off my plate. Eric, I noticed you incorporated some css fixes, would you mind taking those in too? Thanks :-)

#2 Updated by Jean-Philippe Lang about 8 years ago

  • Status changed from New to Closed
  • Target version set to 0.9.0

Applied in r3069.
Note that the patched line was truncated in your diff.

#3 Updated by Felix Schäfer about 8 years ago

Thanks, and sorry for the truncated diff.

Also available in: Atom PDF