Project

General

Profile

Actions
Copy link

Patch #4299

closed

Add tabindex to login screen

Added by Henrik Ammer over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
0.9.0
Start date:
2009-11-27
Due date:
% Done:

0%

Estimated time:

Description

When on the loginscreen there were no tabindex' defined.

I made it follow the login, password, open id, stay logged in and finally the login button (therefor skipping the "lost password" link.

However, the checkbox autologin is now set to true as default since check_box_tag could not set any options of not both value and checked status was defined. If it should be false as default I can ofcourse fix that to.

Note that this was mostly a test on how to make patches and therefor I did one for the thing that was an easy fix for not that big a problem. :)

Patched from r3092.

Files

Download all files
tabindex_loginpage.diff (1.55 KB) tabindex_loginpage.diff Henrik Ammer, 2009-11-27 12:59
tabindex_loginpage_fixed.diff (1.6 KB) tabindex_loginpage_fixed.diff Fixed diff to be created in the redmine directory (as it should be) Henrik Ammer, 2009-11-27 13:31

Related issues

Has duplicate Redmine - Feature #4429: Optimize login form for keybord accessClosed2009-12-17

Actions
Actions
Copy link
 #1

Updated by Henrik Ammer over 14 years ago

One rookie mistake: I didn't run the svn diff in the redmine directorybut in the app/views/account directory. I'm adding a new patch that fixes this.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 14 years ago

  • Category set to UI
  • Status changed from New to Closed
  • Target version set to 0.9.0

Patch committed in r3098 with slight change (autologin should definitely stay disabled by default).
Thanks.

Actions
Copy link

Also available in: Atom PDF