Defect #4998

Global issue list's context menu has enabled options for parent menus but there are no valid selections

Added by Eric Davis about 2 years ago. Updated over 1 year ago.

Status:Closed Start date:2010-03-05
Priority:Low Due date:
Assignee:Jean-Baptiste Barth % Done:

100%
Category:UI
Target version:1.0.2
Affected version: Resolution:Fixed

Description

A client brought this bug to my attention. On the global issues list:

  • Select two issues on different projects
  • Right click to trigger the context menu
  • Some options with a submenu are enabled but the selections are not (Priority, % Done). e.g. It shows you can change Priority but doesn't present any values you can select.

issues_controller.rb.patch (2 kB) Magnifier Alain Alain091, 2010-05-01 19:58

issues_controller.rb.patch (2 kB) Magnifier Alain Alain091, 2010-05-02 10:44

Associated revisions

Revision 4059
Added by Jean-Baptiste Barth over 1 year ago

Do not display items without valid selection in context menu when on different projects. #4998

History

#1 Updated by Jean-Philippe Lang about 2 years ago

  • Category changed from Issues to UI
  • Priority changed from Normal to Low

#2 Updated by Alain Alain091 about 2 years ago

find attached a patch which take into account rights of each project for evaluate the access to actions in menus.

The rule is an AND operation between the rights in each project. If one is false, the entire action is set to false.

#3 Updated by Alain Alain091 about 2 years ago

I was impatient to post my modifications

But, if the idea of correction was correct my code contained errors

Here a better patch.

#4 Updated by Alain Alain091 about 2 years ago

I think that the correct statment is :

edit = edit && expression

and not edit &= expression

#5 Updated by Jean-Baptiste Barth almost 2 years ago

Same here at work on 1.0.0(RC), it's really annoying and should be fixed for 1.0.1 in my opinion. Alain: I'll take a look at your patch.

#6 Updated by Jean-Baptiste Barth over 1 year ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Baptiste Barth
  • Target version set to 1.0.2
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Alain: your patch is a first step to handle cross-projects issues in context menu, which is a much larger issue (see #5332).

I prefer just hiding those items for the moment, which solves the exact issue Eric reported. It's committed in r4059. We may work on bulk edit later, in #5332.

#7 Updated by Eric Davis over 1 year ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable for release in 1.0.2

Also available in: Atom PDF