Defect #5548

SVN Repository: Can not list content of a folder which includes square brackets.

Added by Xuan SONG 4 months ago. Updated 2 months ago.

Status:Closed Start:2010-05-18
Priority:Normal Due date:
Assigned to:Eric Davis % Done:

100%
Category:SCM
Target version:1.0.0 (RC)
Affected version:devel Resolution:Fixed

Description

Operation:
1. Create a folder in SVN's repository. The folder's name includes square brackets, such as [dir1].
2. Add something (files and/or folders) into the folder created above.
3. Confirm them can be displayed correctly by SVN's client.
4. In Redmine's repository, click [dir1] to display its content.

After step4, the The entry or revision was not found in the repository. is displayed.

Environment:
1. Client(WinXP):TortoiseSVN
2. Server(RHEL5):CollabNet Subversion(1.6.6) + redmine(0.9.4) + Postgresql(8.4.3)

patch.diff - test case and fix (38.4 KB) Gregor Schmidt, 2010-06-20 15:14

0001-adding-test-for-5548-square-brackets-in-svn-paths.patch (35.4 KB) Gregor Schmidt, 2010-06-20 15:15

0002-fix-for-5548-escaping-in-svn-urls.patch (3.7 KB) Gregor Schmidt, 2010-06-20 15:15

0003-updating-test-case-to-work-with-updated-svn-test-rep.patch (1.2 KB) Gregor Schmidt, 2010-06-20 15:40

patch.diff (39.2 KB) Gregor Schmidt, 2010-06-20 15:40

Associated revisions

Revision 3800
Added by Eric Davis 2 months ago

Support listing directories in svn which include square brackets. #5548

Contributed by Gregor Schmidt

History

Updated by Felix Schäfer 4 months ago

  • Assigned to deleted (Felix Schäfer)

I was able to reproduce this.

Updated by ww yhy 3 months ago

I have same problem.

SCM: Subversion
URL: http://10.121.120.15/svn/ChoSEE/src/mkend/src/
Login: wwyhy
Password: 123456

I got below error:

The entry or revision was not found in the repository.

Updated by ww yhy 3 months ago

ww yhy wrote:

I have same problem.

SCM: Subversion URL: http://ip/svn/test/src/md/src/ Login: wwyhy Password: 123456

I got below error:

The entry or revision was not found in the repository.

Updated by Felix Schäfer 2 months ago

  • Target version set to 1.0.0 (RC)

Updated by Gregor Schmidt 2 months ago

The basic problem seems to be an incompatibility of the URL RFC1738 and Ruby's URI.escape. The former assumes square brackets unsafe, the latter treats them as safe characters. Therefore they are not properly escaped when building the SVN URL.

I will try to add a failing test and add the necessary escaping.

Updated by Gregor Schmidt 2 months ago

In the mean time I have added a bug report to Ruby.

Updated by Gregor Schmidt 2 months ago

Attached you may find a patch adding a test case and a possible fix.

I had to change the svn test repository, so please regenerate it after applying the patch with 

rm -fr tmp/test/subversion_repository
rake test:scm:setup:subversion

Updated by Gregor Schmidt 2 months ago

For those prefering git, here is the same patch in gits format-patch format.

Updated by Gregor Schmidt 2 months ago

Please note, that the fix breaks support for IPv6-Urls. But I think those are currently less likely to occur than square brackets.

IPv6 support may be fixed once Ruby issue #3457 is solved.

Updated by Gregor Schmidt 2 months ago

Another functional test was affected by the change in the test repository. Attached are updated patch files.

Updated by Eric Davis 2 months ago

  • Status changed from New to Closed
  • Assigned to set to Eric Davis
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Committed in r3800, thank you for the bug report and patch.

Also available in: Atom PDF