Defect #5775

ldap authentication in admin menu should have an icon

Added by Bernhard Furtmueller over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Eric Davis% Done:

0%

Category:UI
Target version:1.0.1
Resolution:Fixed Affected version:

Description

In app/views/admin/_menu.rhtml the entry label_ldap_authentication doesn't contain a class and therefore no icon is displayed.

The link in Administration menu was introduced in r3744.

key_go.png (744 Bytes) Holger Just, 2010-07-03 13:20

group_key.png (813 Bytes) Holger Just, 2010-07-03 13:20

database_connect.png (763 Bytes) Jan from Planio www.plan.io, 2010-07-19 19:23

server_key.png (746 Bytes) Jan from Planio www.plan.io, 2010-07-19 19:23

Associated revisions

Revision 3859
Added by Eric Davis over 7 years ago

Added icon for the LDAP authentication menu item. #5775

History

#1 Updated by Holger Just over 7 years ago

I would propose the key_go icon of famfamfam for now.

Once we are able to define complete authentication modules in redmine and be able to configure those in a combined GUI, I would propose the group_key icon.

#2 Updated by Jan from Planio www.plan.io over 7 years ago

  • Assignee set to Eric Davis

fwiw, these two from famfamfam would work as well imho. but we should definitely get one of them into the final (non RC) 1.0 release.

#3 Updated by Jan from Planio www.plan.io over 7 years ago

missed the attachments...

#4 Updated by Eric Davis over 7 years ago

  • Status changed from New to Resolved
  • Target version set to 1.0.1
  • Resolution set to Fixed

Thanks everyone, I was going to add one but forgot about it while doing the release. I ended up using the server key and giving it a css class so other server authentication types can reuse it.

r3859

#5 Updated by Eric Davis over 7 years ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable in r3862.

Also available in: Atom PDF