Patch #6317

Template names conventions

Added by Jean-Baptiste Barth about 7 years ago. Updated almost 5 years ago.

Status:ClosedStart date:2010-09-07
Priority:LowDue date:
Assignee:Toshi MARUYAMA% Done:

50%

Category:Code cleanup/refactoring
Target version:-

Description

Can we update template names to rails 2.x conventions (rhtml -> html.erb) ? Or at least clean the render :template with filenames hardcoded in controllers which can make a plugin developer not understanding why his view his not overriding the core's one ?

Any thought/pros/cons about that ?


Related issues

Related to Redmine - Feature #4796: Rails 3 support Closed 2010-02-10

Associated revisions

Revision 7022
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from IssuesController 'index' (#6317).

Revision 7023
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from IssuesController 'show' (#6317).

Revision 7024
Added by Toshi MARUYAMA about 6 years ago

respond nothing in case of content type is not html with invalid query params (#8883, #6317).

Revision 7025
Added by Toshi MARUYAMA about 6 years ago

add test to respond nothing in case of content type is html with invalid query params (#8883, #6317).

Revision 7026
Added by Toshi MARUYAMA about 6 years ago

add test to respond nothing in case of content type is not html with invalid query params (#8883, #6317).

Revision 7027
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_show_by_anonymous" of functional issues controller test (#6317).

Revision 7028
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project_and_default_filter" of functional issues controller test (#6317).

Revision 7029
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project_and_empty_filters" of functional issues controller test (#6317).

Revision 7030
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_query" of functional issues controller test (#6317).

Revision 7031
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_query_grouped_by_tracker" of functional issues controller test (#6317).

Revision 7032
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_query_grouped_by_list_custom_field" of functional issues controller test (#6317).

Revision 7034
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index" of functional issues controller test (#6317).

Revision 7035
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_should_not_list_issues_when_module_disabled" of functional issues controller test (#6317).

Revision 7039
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project" of functional issues controller test (#6317).

Revision 7040
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project_and_subprojects_should_show_private_subprojects" of functional issues controller test (#6317).

Revision 7041
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project_and_subprojects" of functional issues controller test (#6317).

Revision 7042
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rhtml' from "test_index_with_project_and_filter" of functional issues controller test (#6317).

Revision 7043
Added by Toshi MARUYAMA about 6 years ago

rename .rhtml to .html.erb of app/views/issues/show.rhtml (#6317).

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 7044
Added by Toshi MARUYAMA about 6 years ago

rename .rhtml to .html.erb of app/views/issues/index.rhtml (#6317).

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 7485
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rxml' from "test_index_atom_feed" of functional activities controller test (#6317)

Revision 7534
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/layouts/mailer.text.plain.erb to app/views/layouts/mailer.text.erb (#6317)

Revision 7535
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/layouts/mailer.text.html.erb to app/views/layouts/mailer.html.erb (#6317)

Revision 7536
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/mailer/*.text.plain.rhtml to app/views/mailer/*.text.erb (#6317)

Revision 7537
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/mailer/*.text.html.rhtml to app/views/mailer/*.html.erb (#6317)

Revision 7566
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/mailer/_issue_text_plain.rhtml to app/views/mailer/_issue.text.erb (#6317)

Revision 7567
Added by Toshi MARUYAMA about 6 years ago

Rails3: mail: rename app/views/mailer/_issue_text_html.rhtml to app/views/mailer/_issue.html.erb (#6317)

Revision 7573
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rxml' from ApplicationController 'render_feed' (#6317)

Revision 7574
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rxml' from 'test_index_atom' at functional projects controller test (#6317)

Revision 7575
Added by Toshi MARUYAMA about 6 years ago

Rails3: rename app/views/common/feed.atom.rxml to app/views/common/feed.atom.builder (#6317)

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 7576
Added by Toshi MARUYAMA about 6 years ago

remove hard-coded '.rxml' from 'test_show_atom' at functional issues controller test (#6317)

Revision 7577
Added by Toshi MARUYAMA about 6 years ago

Rails3: rename app/views/journals/index.rxml to app/views/journals/index.builder (#6317)

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 8304
Added by Toshi MARUYAMA almost 6 years ago

Rails3: rename sample_plugin .rhtml to .html.erb (#6317, #4796)

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 9261
Added by Toshi MARUYAMA over 5 years ago

simple_ci plugin: rename *.rhtml to *.html.erb (#6317)

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

Revision 9264
Added by Toshi MARUYAMA over 5 years ago

embedded plugin: rename *.rhtml to *.html.erb (#6317)

:rhtml and :rxml were finally removed as template handlers at Rails 3.1 RC4.

History

#1 Updated by Jean-Baptiste Barth about 6 years ago

  • Status changed from New to 7
  • Assignee set to Toshi MARUYAMA
  • Target version set to Candidate for next major release
  • % Done changed from 0 to 50

I think Toshi is taking care of that one these days, thanks. Toshi: I'll let you update this issue accordingly. I set the "% Done" to 50% since there was 226 templates with ".rhtml" convention in Redmine 1.2.0 and now 109 in current trunk. Keep up the good work!

#2 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from 7 to Closed
  • Target version deleted (Candidate for next major release)

I think this one is complete now.

Also available in: Atom PDF