Defect #6447

Issues API doesn't allow full key auth for all actions

Added by Eric Davis about 7 years ago. Updated almost 7 years ago.

Status:ClosedStart date:2010-09-20
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:REST API
Target version:1.0.4
Resolution:Fixed Affected version:1.0.1

Description

Needs an accept_key_auth so full key actions can work (i.e. not HTTP basic based keys).

Simple fix but I want to have a solid test suite for this so we can reuse it as new APIs are added.


Related issues

Related to Redmine - Defect #6841: Projects API doesn't allow full key auth for all actions Closed 2010-09-20

Associated revisions

Revision 4358
Added by Eric Davis about 7 years ago

Refactor: convert api key tests to shoulda macros for reuse. #6447

Revision 4360
Added by Eric Davis about 7 years ago

Refactor: convert username/password http basic auth api tests to shoulda macros #6447

Revision 4364
Added by Eric Davis about 7 years ago

Refactor: Convert the tests for Issues#index and #show APIs to shoulda. #6447

Revision 4365
Added by Eric Davis about 7 years ago

Allow key authentication when creating issues (with tests) #6447

Revision 4366
Added by Eric Davis about 7 years ago

Allow key authentication when updating issues (with tests) #6447

Revision 4367
Added by Eric Davis about 7 years ago

Allow key authentication when deleting issues (with tests) #6447

History

#1 Updated by takatomo okitsu about 7 years ago

Please fix this problem before cording test suite? minimum fix about issues_controller.rb and project_controller.rb.

#2 Updated by Eric Davis about 7 years ago

  • Status changed from New to 7

I'm working on this now by cleaning up the existing tests to see which actions are missing the auth key option.

#3 Updated by Eric Davis about 7 years ago

  • Status changed from 7 to Resolved
  • Target version set to 1.0.4
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Fixed in various commits over this week. Now the basic issues API should allow authentication with any of the methods Redmine supports.

I also rewrote the test suite for the Issues API so it's much more through now. (391 tests, 403 assertions)

#4 Updated by Eric Davis almost 7 years ago

  • Assignee deleted (Eric Davis)

I am stepping down from working on Redmine. If someone else is interesting in working on this issue, feel free to reassign it to them.

Eric Davis

#5 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed

All the required changes are merged in 1.0-stable (r4439).

Also available in: Atom PDF