Project

General

Profile

Actions

Defect #6452

closed

Unhandled exception on creating File

Added by Jan from Planio www.plan.io about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Attachments
Target version:
Start date:
2010-09-21
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Creating (uploading) a file yields an unhandled exception in Mailer#attachments_added whenever the attachment fails to be validated (e.g. filesize too large) and email notifications are turned on.

Exception:

NoMethodError: undefined method `container' for nil:NilClass

Relavant stacktrace:

--- 
- "[RAILS_ROOT]/app/models/mailer.rb:110:in `attachments_added'" 
- "[RAILS_ROOT]/app/controllers/files_controller.rb:32:in `create'" 

This patch fixes the problem. Please check and commit.


Files

files_controller_patch.patch (698 Bytes) files_controller_patch.patch Jan from Planio www.plan.io, 2010-09-21 12:27
Actions #1

Updated by Jan from Planio www.plan.io about 14 years ago

this is an easy one, would be great if it made it into 1.0.2

Actions #2

Updated by Jean-Philippe Lang about 14 years ago

  • Status changed from New to Resolved
  • Target version set to 1.0.2
  • Resolution set to Fixed

Fixed in r4177.

Actions #3

Updated by Jan from Planio www.plan.io about 14 years ago

Thanks :)

Actions #4

Updated by Eric Davis about 14 years ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable

Actions

Also available in: Atom PDF