Patch #6498

Make options parameter optional in User#allowed_to_globally?

Added by Jan from Planio www.plan.io over 7 years ago. Updated over 3 years ago.

Status:ClosedStart date:2010-09-26
Priority:NormalDue date:
Assignee:Jean-Baptiste Barth% Done:

0%

Category:Permissions and roles
Target version:2.6.0

Description

It's optional in allowed_to? so it would make sense to make it optional in allowed_to_globally?, too.

Patch is attached.

user.rb.patch Magnifier (476 Bytes) Jan from Planio www.plan.io, 2010-09-26 20:13

Associated revisions

Revision 13364
Added by Jean-Baptiste Barth over 3 years ago

Make 2nd parameter optional in User#allowed_to_globally? for consistency (#6498).

History

#1 Updated by Victor Ilyukevich about 7 years ago

+1

#2 Updated by Jean-Baptiste Barth over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Baptiste Barth
  • Target version set to 2.6.0

Yes obviously. This method is not used anywhere in the Redmine code base anymore, but I find lots of usages in plugins on Github (https://github.com/search?o=desc&q=allowed_to_globally&s=indexed&type=Code)

On a side note Jan: I'm trying to spend some time reviewing/merging patches these days, and obviously 4 years old patches with not even a reply are ridiculous. If you want to drop me an email with things you think I can merge directly, let me know (or we can chat about that on freenode eventually, nick=salvor but my IRC client is at $WORK so I'm only behind on weekdays).

Also available in: Atom PDF