Patch #6688

Improvements for query-views of Calendar and Gantt

Added by Mischa The Evil about 7 years ago. Updated about 4 years ago.

Status:ClosedStart date:2010-10-18
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

Over the last few days I have been prepping a patch which includes the following changes:
  • Retain action when applying custom query (changes partly incorporated from #6157)
  • When custom query is active, show the custom query name (as in issue-lists) on Calendar & Gantt (undo regression added for #2883 -> in r2892)
  • When custom query is active, query reset-button isn't rendered on Calendar & Gantt (error introduced after Gantt- and Calendar-refactoring for Redmine 1.1.x, reported in #6473 -> fixed incorrectly in r4176)
  • Move Calendar & Gantt links from issue _sidebar partial to projects-index view (inconsistent location for the links -> move to other global links placeholder awaiting changes for #5920)
  • Remove remaining :view_issues_sidebar_planning_bottom hook (has become obsolete)

I haven't tested these changes thoroughly, but decided to upload it as it is currently due to upcoming lack of spare time. Please improve, update and incorporate if complete.

query_enhancements_in_calendar_and_gantt-r4249.diff Magnifier - Patch against trunk at r4249 (4.97 KB) Mischa The Evil, 2010-10-18 06:27


Related issues

Related to Redmine - Feature #5920: Unify and improve cross-project views layout Closed 2010-07-21
Related to Redmine - Defect #6473: New gantt broken after clearing issue filters Closed 2010-09-23
Related to Redmine - Defect #6157: Applying custom queries should not redirect away from cal... Closed
Related to Redmine - Feature #2883: custom reports based on query Closed 2009-03-02
Related to Redmine - Feature #4603: Add projects-breadcrumb to Gantt and Calendar views endin... New 2010-01-19

History

#1 Updated by Mischa The Evil almost 7 years ago

I'll look into incorporating the changes from issue #4603 into this patch.

#2 Updated by Mischa The Evil about 4 years ago

  • Status changed from New to Closed
  • Retain action when applying custom query (changes partly incorporated from #6157)

This was fixed in r4909.

  • When custom query is active, show the custom query name (as in issue-lists) on Calendar & Gantt (undo regression added for #2883 -> in r2892)

This was fixed in r4910.

  • When custom query is active, query reset-button isn't rendered on Calendar & Gantt (error introduced after Gantt- and Calendar-refactoring for Redmine 1.1.x, reported in #6473 -> fixed incorrectly in r4176)

This was fixed in r4911.

  • Move Calendar & Gantt links from issue _sidebar partial to projects-index view (inconsistent location for the links -> move to other global links placeholder awaiting changes for #5920)

Doesn't really belong to the initial idea for this issue and patch and can be much better handled via, preferably, #5920 or alternatively #4603.

  • Remove remaining :view_issues_sidebar_planning_bottom hook (has become obsolete)

Up to today the hook is still present. Main reason for this is most likely to be plugin compatibility. By removing the hook, plugins using it need to switch to the remaining :view_issues_sidebar_issues_bottom hook (not to speak about the deprecation process and time that takes, and that for just one hook).
And again: this doesn't really belong to the initial idea for this issue and patch.

I'll look into incorporating the changes from issue #4603 into this patch.

A fresh look at this tells me that it should be kept apart from this issue.

Considering all the above I say this patch has become obsolete; closing as such.

Also available in: Atom PDF