Defect #6740

Max attachment size, incorrect usage of 'KB'

Added by Alex Cartwright about 7 years ago. Updated almost 7 years ago.

Status:ClosedStart date:2010-10-25
Priority:NormalDue date:2010-11-26
Assignee:Azamat Hackimov% Done:

100%

Category:Translations
Target version:1.0.4
Resolution:Fixed Affected version:1.0.3

Description

When I came to change the maximum attachment size, I was confused about the 'KB' prefix used, since 'KB' is not a standard prefix for anything. After doing some quick calculations I actually found out that this field is kilobytes, which is the SI decimal prefix 'kB'.

It would be good if this could be changed from 'KB' to 'kB' to stop confusion, and so we actually know what this fields value is representing.

Associated revisions

Revision 4300
Added by Azamat Hackimov about 7 years ago

Fixing "Kilobyte" prefix to kB (#6740)

Revision 4426
Added by Azamat Hackimov almost 7 years ago

Replaced hardcoded strings (KB) with i18n equivalent (number.human.storage_units.units.kb)
Fixes #6740 finally

History

#1 Updated by Holger Just about 7 years ago

  • Category set to Translations
  • Assignee set to Azamat Hackimov

#2 Updated by Azamat Hackimov about 7 years ago

  • Due date set to 2010-10-28
  • Status changed from New to Resolved
  • Target version set to 1.0.3

Fixed in r4300.

#3 Updated by Eric Davis about 7 years ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable for release in 1.0.3

#4 Updated by Alex Cartwright about 7 years ago

Are we sure this was fixed? I'm running 1.0.3.stable.4387 and yet I'm still seeing 'KB' instead of 'kB'.

#5 Updated by Holger Just about 7 years ago

It was merged in r4335.

#6 Updated by Alex Cartwright about 7 years ago

Holger Just wrote:

It was merged in r4335.

Sure, that doesn't mean it's fixed though and I can confirm this isn't. The 'KB' is hard coded into 'app/views/settings/_general.rhtml' ;)

#7 Updated by Alex Cartwright almost 7 years ago

Just wondering if someone could give a response as to the status of this.

#8 Updated by Azamat Hackimov almost 7 years ago

  • Due date deleted (2010-10-28)
  • Status changed from Closed to Reopened
  • Target version changed from 1.0.3 to 1.0.4
  • Affected version (unused) set to 1.0.3
  • Affected version set to 1.0.3

I'll fix this issue.

#9 Updated by Azamat Hackimov almost 7 years ago

  • Due date set to 2010-11-26
  • Status changed from Reopened to Resolved
  • Resolution set to Fixed

Fixed in r4426.

#10 Updated by Azamat Hackimov almost 7 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

Applied in changeset r4426.

#11 Updated by Azamat Hackimov almost 7 years ago

  • Status changed from Closed to Reopened

Heh, autoclosing working! :)

#12 Updated by Azamat Hackimov almost 7 years ago

  • Status changed from Reopened to Resolved

#13 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed

Azamat, thanks for your fix.
Merged in 1.0-stable.

Also available in: Atom PDF