Project

General

Profile

Actions

Feature #7410

closed

Add salt to user passwords

Feature #7410: Add salt to user passwords

Added by Jean-Philippe Lang almost 16 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Accounts / authentication
Target version:
Resolution:
Fixed

Description

User passwords are stored as SHA1(password) which makes them vulnerable to a dictionary attack from an attacker who gets access to the database.

The change consists of generating a salt for each user and storing SHA1(salt+SHA1(password)) in the database.


Related issues 2 (0 open — 2 closed)

Related to Redmine - Feature #6394: Add Salt to AuthenticationClosedActions
Related to Redmine - Defect #8514: Custom Password storing break pam_mysqlClosedActions

Updated by Eric Thomas almost 16 years ago Actions #1

Duplicates #6394.

Updated by Jean-Philippe Lang over 15 years ago Actions #2

  • Status changed from New to Closed
  • Resolution set to Fixed

Feature committed in r4936.

Updated by Rick I over 15 years ago Actions #3

So now if attacker gets hold of the database all he has to do is to remove leading salt (since salt is stored in DB) and proceed with the dictionary attack. I don't see how this makes password any more secure...

Updated by Rick I over 15 years ago Actions #4

Rick I wrote:

So now if attacker gets hold of the database all he has to do is to remove leading salt (since salt is stored in DB) and proceed with the dictionary attack. I don't see how this makes password any more secure...

Edit:
I take it all back. I didn't see salt+password_hash is hashed again.. my bad :F

Updated by Go MAEDA almost 6 years ago Actions #5

  • Related to Defect #8514: Custom Password storing break pam_mysql added
Actions

Also available in: PDF Atom