Project

General

Profile

Actions

Defect #8537

closed

Error in copying projects

Added by Luis Serrano Aranda almost 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Projects
Target version:
-
Start date:
2011-06-06
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If the copy of a project takes (the project is long) and re-click the copy button, Redmine allows this action and copy two projects with exactly the same characteristics (id and name included).

It would be possible disable the copy button, until the copy is complete or there is a time out ?

Thanks


Related issues

Related to Redmine - Defect #6579: Tree hierachy being currupted on multiple submissions of an issueClosedJean-Philippe Lang2010-10-05

Actions
Related to Redmine - Feature #23630: Migrate to Rails 5.2ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Luis Serrano Aranda almost 13 years ago

Addint a message like Loading... But typing Working...

Actions #2

Updated by Luis Serrano Aranda almost 13 years ago

A possible solution is to add this code at the end of prototype.js, disable the button until the task is completed.

var SubmitHelper = {
disableFormsOfPage: function(){
$$('form').each(function(form) {
form.observe('submit', function() {
form.getInputs('submit').each(function(submit) {
if (!submit.readAttribute("no_disabled")){
submit.disable();
}
});
});
});
},
init: function(){
Event.observe(window, 'load', SubmitHelper.disableFormsOfPage.bindAsEventListener())
}
}

SubmitHelper.init();

Actions #3

Updated by Luis Serrano Aranda almost 13 years ago

This a workaround, but not solve the concurrently, the backward...

I think it's better write a flag in the server (to not copy a project concurrently)

Actions #4

Updated by Masamitsu Murase over 12 years ago

I think that this workaround does not work when an user select "Create and continue" button,
because "continue" parameter is not sent to the server if "Create and continue" is disabled.

Therefore,

  if (!submit.readAttribute("no_disabled")){
    submit.disable();
  }

should be
  if (!submit.readAttribute("no_disabled")){
    setTimeout(function(){ submit.disable(); }, 0);
  }

Please refer to my plugin.
(This plugin works on only "Issue" page currently...)

Regards,
Murase

Actions #5

Updated by Go MAEDA over 5 years ago

Actions #6

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

It will be fixed in Redmine 4.0.0. Rails 5 automatically disables submit buttons while executing an action. See also: https://github.com/rails/rails/pull/21135

Actions

Also available in: Atom PDF