Defect #9252

Regression: application title escaped 2 times

Added by Etienne Massip about 6 years ago. Updated about 6 years ago.

Status:ClosedStart date:2011-09-15
Priority:NormalDue date:
Assignee:Toshi MARUYAMA% Done:

0%

Category:Code cleanup/refactoring
Target version:1.3.0
Resolution:Fixed Affected version:1.1.0

Description

Since of r6350, ApplicationHelper#html_title returns an HTML escaped string, but the base layout escape it again.

As a result, if you are watching issue which Subject field value is something like:

"error.log" is empty

You'll get this string in your browser title bar:

Redmine - Issues #1234: "error.log" is empty

Related issues

Related to Redmine - Feature #4796: Rails 3 support Closed 2010-02-10

Associated revisions

Revision 7246
Added by Toshi MARUYAMA about 6 years ago

backed out r6350 (#9252, #4796)

HTML escape at app/helpers/application_helper.rb

Revision 7247
Added by Toshi MARUYAMA about 6 years ago

HTML escape at link_to_revision() of app/helpers/application_helper.rb (#9252)

Revision 7248
Added by Toshi MARUYAMA about 6 years ago

HTML escape at parse_wiki_links() of app/helpers/application_helper.rb (#9252)

Revision 7249
Added by Toshi MARUYAMA about 6 years ago

HTML escape at parse_redmine_links() of app/helpers/application_helper.rb (#9252)

Revision 7250
Added by Toshi MARUYAMA about 6 years ago

HTML escape at context_menu_link() of app/helpers/application_helper.rb (#9252)

Revision 7565
Added by Etienne Massip about 6 years ago

Remove unecessary page title HTML escaping from views (#9252).

History

#1 Updated by Etienne Massip about 6 years ago

  • Target version changed from Candidate for next minor release to Candidate for next major release

#2 Updated by Etienne Massip about 6 years ago

  • Target version changed from Candidate for next major release to 1.3.0

#4 Updated by Etienne Massip about 6 years ago

  • Affected version (unused) changed from devel to 1.1.0
  • Affected version set to 1.1.0

This issue is already present in Redmine 1.1.x when viewing forum message, see RE: "Object is not missing constant Issue!" on CentOS 5.5.

#5 Updated by Etienne Massip about 6 years ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

#6 Updated by Jean-Philippe Lang about 6 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF