Defect #9775

app/views/repository/_revision_graph.html.erb sets window.onload directly..

Added by John Kubiatowicz almost 6 years ago. Updated almost 6 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:1.3.1
Resolution:Fixed Affected version:1.3.0

Description

The subject says it all. The partial _revision_graph.html.erb (in app/views/repository) sets window.onload directly. As a result of setting window.onload directly, it toasts other onload events on the repository page (currently messing with a plugin that I have).

Instead of:

window.onload = function() { stuff; };

should use the prototype syntax used elsewhere in Redmine:

Event.observe(window,"load",function(){ stuff; });

I believe that this started showing up when I pulled down the 1.2.2 updates (not entire sure of timeline)

Associated revisions

Revision 8209
Added by Jean-Philippe Lang almost 6 years ago

Fixed that _revision_graph.html.erb breaks window load events (#9775).

Revision 8765
Added by Jean-Philippe Lang almost 6 years ago

Merged r8209 from trunk (#9775).

History

#1 Updated by Jean-Philippe Lang almost 6 years ago

  • Category set to SCM
  • Status changed from New to Resolved
  • Target version set to 1.3.1
  • Affected version (unused) set to 1.3.0
  • Affected version set to 1.3.0

Fixed in r8209.

#2 Updated by Jean-Philippe Lang almost 6 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Merged.

Also available in: Atom PDF