30785-fix-v2.patch - Redmine

Defect #30785 » 30785-fix-v2.patch

Go MAEDA, 2019-02-17 06:01

         @handler_options = options
         sender_email = email.from.to_a.first.to_s.strip
         # Ignore emails received from the application emission address to avoid hell cycles
         if sender_email.casecmp(Setting.mail_from.to_s.strip) == 0
         emission_address = Setting.mail_from.to_s.gsub(/(?:.*<|>.*|\(.*\))/, '').strip
         if sender_email.casecmp(emission_address) == 0
           if logger
             logger.info  "MailHandler: ignoring email from Redmine emission address [#{sender_email}]"
           end

       end
       def test_should_ignore_emails_from_emission_address
         emission_addresses = [
           'redmine@example.net',
           'Redmine <redmine@example.net>',
           'redmine@example.net (Redmine)'
+        ]
         Role.anonymous.add_permission!(:add_issues)
         assert_no_difference 'User.count' do
           assert_equal false,
                        submit_email(
                          'ticket_from_emission_address.eml',
                          :issue => {:project => 'ecookbook'},
                          :unknown_user => 'create'
+                       )
         emission_addresses.each do |addr|
           with_settings :mail_from => addr do
             assert_no_difference 'User.count' do
               assert_equal false,
                           submit_email(
                             'ticket_from_emission_address.eml',
                             :issue => {:project => 'ecookbook'},
                             :unknown_user => 'create'
+                          )
             end
           end
         end
       end

(2-2/2)