Project

General

Profile

Feature #32519 ยป mail-err.patch

Report error message in rdm-mailhandler.rb - Anthony Mallet, 2019-11-26 17:36

View differences:

app/controllers/mail_handler_controller.rb
def index
options = params.dup
email = options.delete(:email)
if MailHandler.safe_receive(email, options)
error = []
if MailHandler.safe_receive(email, options, error)
head :created
else
head :unprocessable_entity
render :plain => error.join('\n'), :status => :unprocessable_entity
end
end
app/models/mail_handler.rb
attr_reader :email, :user, :handler_options
def self.receive(raw_mail, options={})
def self.receive(raw_mail, options={}, error=[])
options = options.deep_dup
options[:issue] ||= {}
......
ActiveSupport::Notifications.instrument("receive.action_mailer") do |payload|
mail = Mail.new(raw_mail)
set_payload_for_mail(payload, mail)
new.receive(mail, options)
new.receive(mail, options, error)
end
end
......
# Processes incoming emails
# Returns the created object (eg. an issue, a message) or false
def receive(email, options={})
def receive(email, options={}, error=[])
@email = email
@handler_options = options
sender_email = email.from.to_a.first.to_s.strip
# Ignore emails received from the application emission address to avoid hell cycles
emission_address = Setting.mail_from.to_s.gsub(/(?:.*<|>.*|\(.*\))/, '').strip
if sender_email.casecmp(emission_address) == 0
error << "Ignoring email from Redmine emission address [#{sender_email}]."
if logger
logger.info "MailHandler: ignoring email from Redmine emission address [#{sender_email}]"
end
......
if value
value = value.to_s.downcase
if (ignored_value.is_a?(Regexp) && value.match(ignored_value)) || value == ignored_value
error << "Ignoring email with #{key}:#{value} header."
if logger
logger.info "MailHandler: ignoring email with #{key}:#{value} header"
end
......
end
@user = User.find_by_mail(sender_email) if sender_email.present?
if @user && !@user.active?
error << "Ignoring email from non-active user [#{@user.login}]."
if logger
logger.info "MailHandler: ignoring email from non-active user [#{@user.login}]"
end
......
::Mailer.deliver_account_information(@user, @user.password)
end
else
error << "Could not create account for [#{sender_email}]."
if logger
logger.error "MailHandler: could not create account for [#{sender_email}]"
end
......
end
else
# Default behaviour, emails from unknown users are ignored
error << "Ignoring email from unknown user [#{sender_email}]."
if logger
logger.info "MailHandler: ignoring email from unknown user [#{sender_email}]"
end
......
end
end
User.current = @user
dispatch
dispatch(error)
end
private
......
ISSUE_REPLY_SUBJECT_RE = %r{\[(?:[^\]]*\s+)?#(\d+)\]}
MESSAGE_REPLY_SUBJECT_RE = %r{\[[^\]]*msg(\d+)\]}
def dispatch
def dispatch(error)
headers = [email.in_reply_to, email.references].flatten.compact
subject = email.subject.to_s
if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
......
end
rescue ActiveRecord::RecordInvalid => e
# TODO: send a email to the user
error << "#{e.message}."
logger.error "MailHandler: #{e.message}" if logger
false
rescue MissingInformation => e
error << "Missing information from #{user}: #{e.message}."
logger.error "MailHandler: missing information from #{user}: #{e.message}" if logger
false
rescue UnauthorizedAction => e
error << "Unauthorized attempt from #{user}."
logger.error "MailHandler: unauthorized attempt from #{user}" if logger
false
end
extra/mail_handler/rdm-mailhandler.rb
"Make sure that 'WS for incoming emails' is enabled in application settings and that you provided the correct API key."
return 77
when 422
warn "Request was denied by your Redmine server. " +
"Possible reasons: email is sent from an invalid email address or is missing some information."
warn response.body
warn "Request was denied by your Redmine server."
return 77
when 400..499
warn "Request was denied by your Redmine server (#{response.code})."
    (1-1/1)