Redmine

  text_close_parent_issue_with_open_subtasks_confirmation: Are you sure you want to close parent issue with open subtasks?

<%= javascript_tag do %>

  $('#issue-form').submit(function(){

    var closedIssueStatusIds =

          <%= @allowed_statuses.select{|i| i.is_closed?}.map{|i| i.id.to_s}.to_json.html_safe  %> ;

    var children = $("#issue_tree").find("tr.issue.child");

    if (($.inArray($("#issue_status_id").val(), closedIssueStatusIds) > -1) &&

        (children.length > 0) &&

        ((children.length - $("#issue_tree").find("tr.issue.child.closed").length) > 0)) {

      if (!confirm(

          "<%= l(:text_close_parent_issue_with_open_subtasks_confirmation) %>"

      )){

        return false;

      }

    }

    $("#issue-form").off('submit');

    $("#issue-form").submit();

  });

<% end %>

  test "add confirm dialog to issue submit button" do

    parent = Issue.generate!(:project_id => 1)

    child = Issue.generate!(:project_id => 1, :parent_issue_id => parent.id)

    with_settings :closed_parent_issues_with_open_subtasks => 1 do

      log_user('dlopper', 'foo')

      visit "/issues/#{parent.id}"

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "New"})

      page.find("#issue_status_id").select("Closed")

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_no_difference 'parent.journals.count' do

          page.dismiss_confirm /Are you sure/ do

            page.first(:button, 'Submit').click

          end

          assert_equal 1, parent.reload.status.id

        end

        assert_difference 'parent.journals.count' do

          page.accept_confirm /Are you sure/ do

            page.first(:button, 'Submit').click

          end

          assert page.has_css?('#flash_notice')

          assert_equal 5, parent.reload.status.id

        end

      end

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "Closed"})

      fill_in 'Subject', :with => 'test of confirm dialog'

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_no_difference 'parent.journals.count' do

          page.dismiss_confirm /Are you sure/ do

            page.first(:button, 'Submit').click

          end

          assert_equal 5, parent.reload.status.id

        end

        assert_difference 'parent.journals.count' do

          page.accept_confirm /Are you sure/ do

            page.first(:button, 'Submit').click

          end

          assert page.has_css?('#flash_notice')

          assert_equal 5, parent.reload.status.id

          assert_equal 'test of confirm dialog', parent.reload.subject

        end

      end

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "Closed"})

      page.find("#issue_status_id").select("New")

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_difference 'parent.journals.count' do

          page.first(:button, 'Submit').click

          assert page.has_css?('#flash_notice')

          assert_equal 1, parent.reload.status.id

        end

      end

      visit "/issues/#{child.id}"

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "New"})

      page.find("#issue_status_id").select("Closed")

      assert_no_difference ['Issue.count', 'parent.journals.count'] do

        assert_difference 'child.journals.count' do

          page.first(:button, 'Submit').click

          assert page.has_css?('#flash_notice')

          assert_equal 5, child.reload.status.id

        end

      end

      visit "/issues/#{parent.id}"

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "New"})

      page.find("#issue_status_id").select("Closed")

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_difference 'parent.journals.count' do

          page.first(:button, 'Submit').click

          assert page.has_css?('#flash_notice')

          assert_equal 5, parent.reload.status.id

        end

      end

    end

  end

    if request.xhr?

      if params[:check_go_to_close_confirm]

        result = true

        status_id = params[:status_id].to_i

        if status_id <= 0

          result = false

        else

          status = IssueStatus.find(status_id)

          if !status.is_closed

            result = false

          else

            result = !@issue.descendants.open.empty?

          end

        end

        render :json => {:result => result}

        return

      end

      return

    end

    var status_id = 0;

    var result = false;

    if ($("#issue_status_id").length > 0) {

      status_id = $("#issue_status_id").val();

    }

    $.ajax({

      url: $("#issue-form").attr('action'),

      type: 'patch',

      async: false,

      data: { 

        "check_go_to_close_confirm": "",

        "status_id": status_id

       },

    })

      .then(

        function(data){

          result = data["result"];

        }

      );

    if (result) {

  test "check_go_to_close_confirm returns false if status_id is not close" do

    issue = Issue.find(1)

    user = User.find(2)

    assert issue.visible?(user)

    assert_not issue.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => issue.id,

        :check_go_to_close_confirm => "",

        :status_id => 1

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal({"result" => false}, json)

  end

  test "check_go_to_close_confirm returns false if status_id is 0" do

    issue = Issue.find(1)

    user = User.find(2)

    assert issue.visible?(user)

    assert_not issue.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => issue.id,

        :check_go_to_close_confirm => "",

        :status_id => 0

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal({"result" => false}, json)

  end

  test "check_go_to_close_confirm returns false if issue does not have child" do

    issue = Issue.generate!

    user = User.find(2)

    assert issue.visible?(user)

    assert_not issue.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => issue.id,

        :check_go_to_close_confirm => "",

        :status_id => 5

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal 1, issue.reload.status.id

    assert_equal({"result" => false}, json)

  end

  test "check_go_to_close_confirm returns true if issue have open child" do

    parent = Issue.generate!

    child = Issue.generate!(:parent_issue_id => parent.id)

    user = User.find(2)

    assert parent.reload.visible?(user)

    assert_not parent.closed?

    assert child.reload.visible?(user)

    assert_not child.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => parent.id,

        :check_go_to_close_confirm => "",

        :status_id => 5

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal 1, parent.reload.status.id

    assert_equal({"result" => true}, json)

  end

  test "check_go_to_close_confirm returns false if child is closed" do

    parent = Issue.generate!

    child = Issue.

              generate!(

                :parent_issue_id => parent.id,

                :status_id => 5

              )

    user = User.find(2)

    assert parent.reload.visible?(user)

    assert_not parent.closed?

    assert child.reload.visible?(user)

    assert child.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => parent.id,

        :check_go_to_close_confirm => "",

        :status_id => 5

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal 1, parent.reload.status.id

    assert_equal({"result" => false}, json)

  end

  test "check_go_to_close_confirm returns true if child is open and not visible" do

    user = User.generate!

    project = Project.generate!

    role = Role.generate!

    role.add_permission! :view_issues, :edit_issues

    role.set_permission_trackers :view_issues, [2]

    role.set_permission_trackers :edit_issues, [2]

    role.save!

    User.add_to_project(user, project, role)

    parent = Issue.

              generate!(

                :project => project,

                :tracker_id => 2,

                :status_id => 1

              )

    child = Issue.

              generate!(

                :project => project,

                :tracker_id => 1,

                :parent_issue_id => parent.id,

                :status_id => 1

              )

    assert parent.reload.visible?(user)

    assert_not parent.closed?

    assert_not child.reload.visible?(user)

    assert_not child.closed?

    @request.session[:user_id] = user.id

    put(

      :update,

      :params => {

        :id => parent.id,

        :check_go_to_close_confirm => "",

        :status_id => 5

      },

      :xhr => true

    )

    assert_response :success

    assert_equal 'application/json', response.content_type

    json = ActiveSupport::JSON.decode(response.body)

    assert_equal 1, parent.reload.status.id

    assert_equal({"result" => true}, json)

  end

      render(

        :partial => 'close_confirm',

        :layout => false,

        :locals => {}

      )

$('#ajax-modal').html(

  '<%= escape_javascript(

         render(

           :partial => 'close_confirm_dialog',

           :locals  => {}

         )

       )

   %>'

);

showModal('ajax-modal', '400px');

<h3 class="title">&nbsp;</h3>

<p>

  <%= l(:text_close_parent_issue_with_open_subtasks_confirmation) %>

</p>

<p class="buttons">

  <%= button_tag l(:button_apply), :type => "button", :onclick => "run_submit();" %>

  <%= link_to_function l(:button_cancel), "hideModal(this);" %>

</p>

<%= javascript_tag do %>

  function run_submit() {

    $("#issue-form").off('submit');

    $("#issue-form").submit();

  }

<% end %>

          if (data["result"]) {

            $.ajax({

              url:   $("#issue-form").attr('action'),

              type: 'patch',

              data: {}

              });

          } else {

            $("#issue-form").off('submit');

            $("#issue-form").submit();

          }

    return false;

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/Are you sure/)

            page.first(:link, 'Cancel').click

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/Are you sure/)

            page.first(:button, 'Apply').click

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/Are you sure/)

            page.first(:link, 'Cancel').click

        page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/Are you sure/)

            page.first(:button, 'Apply').click

        status = nil

        can_close_all_descendants = true

            opened_descendants = []

            @issue.descendants.open.sort_by(&:lft).each do |issue|

              unless issue.visible?

                can_close_all_descendants = false

                break

              end

              unless issue.new_statuses_allowed_to.map{|i| i.id}.include?(status.id)

                can_close_all_descendants = false

                break

              end

              opened_descendants << issue

            end

            if can_close_all_descendants && opened_descendants.empty?

              result = false

              can_close_all_descendants = false

            end

          end

          if result

            session[:can_close_descendant] = {}

            session[:can_close_descendant][:can_close_all] = can_close_all_descendants

            if can_close_all_descendants

              session[:can_close_descendant][:status_id] = status.id

              session[:can_close_descendant][:status_name] = status.name

              session[:can_close_descendant][:ids] = opened_descendants.map{|i| i.id}

            end

      if !session.has_key?(:can_close_descendant)

        return

      end

      render_data = {

        :status_name => session[:can_close_descendant][:status_name],

        :can_close_all => session[:can_close_descendant][:can_close_all]

      }

        :locals => render_data

      if params[:close_descendants] && session.has_key?(:can_close_descendant)

        close_descendant_ids = session[:can_close_descendant][:ids]

        session.delete(:can_close_descendant)

        close_descendant_ids.each do |id|

          issue = Issue.find(id)

          issue.init_journal(User.current, params[:issue][:notes])

          issue.safe_attributes = {'status_id' => params[:issue][:status_id].to_i}

          issue.save

        end

      end

           :locals  => {

             :status_name => status_name,

             :can_close_all => can_close_all

           }

<% if can_close_all %>

  <p>

    <%= l(:text_close_parent_issue_and_open_subtasks,

          :issue_id => params[:id]) %>

  </p>

  <p>

    <label class="block">

      <%= radio_button_tag 'choice', '1' %>

      <%= l(:text_close_parent_issue_and_open_subtasks_choice_close_also_all_subtasks,

            :status => status_name) %>

    </label>

    <label class="block">

      <%= radio_button_tag 'choice', '2', true %>

      <%= l(:text_close_parent_issue_and_open_subtasks_choice_close_only_parent,

            :issue_id => params[:id]) %>

    </label>

  </p>

<% else %>

  <p>

    <%= l(:text_close_parent_issue_with_open_subtasks_confirmation) %>

  </p>

<% end %>

    var canCloseAll = <%= can_close_all %>;

    if (canCloseAll) {

      var radioVal = $("input[name='choice']:checked").val();

      if (radioVal == '1') {

        $('<input />').attr('type', 'hidden')

            .attr('name', "close_descendants")

            .appendTo('#issue-form');

      }

    }

  text_close_parent_issue_and_open_subtasks: Issue %{issue_id} has open subtasks.

  text_close_parent_issue_and_open_subtasks_choice_close_also_all_subtasks: Close all open subtasks by "%{status}" status too

  text_close_parent_issue_and_open_subtasks_choice_close_only_parent: Close only issue %{issue_id}

    hidden_child =

      Issue.

        generate!(

          :project_id => 1,

          :parent_issue_id => parent.id,

          :author_id => 2,

          :is_private => true

        )

    assert_not hidden_child.visible?(User.find(3))

      hidden_child.status_id = 5

      hidden_child.save!

    assert_not session.has_key?(:can_close_descendant)

    assert_not session.has_key?(:can_close_descendant)

    assert_not session.has_key?(:can_close_descendant)

    assert session.has_key?(:can_close_descendant)

    assert_not session.has_key?(:can_close_descendant)

    assert session.has_key?(:can_close_descendant)

    assert_not session[:can_close_descendant][:can_close_all]

  test "close all descendants which are open" do

    with_settings :closed_parent_issues_with_open_subtasks => 1 do

      parent = Issue.generate!

      child =

        Issue.

         generate!(

           :parent_issue_id => parent.id

         )

      grandchild1 =

        Issue.

          generate!(

            :parent_issue_id => child.id

          )

      grandchild2 =

        Issue.

         generate!(

           :parent_issue_id => child.id,

           :status_id => 6

         )

      user = User.find(2)

      assert parent.reload.visible?(user)

      assert_not parent.closed?

      assert child.reload.visible?(user)

      assert_not child.closed?

      assert grandchild1.reload.visible?(user)

      assert_not grandchild1.closed?

      assert grandchild2.reload.visible?(user)

      assert grandchild2.closed?

      assert [parent, child, grandchild1, grandchild2].

               map{|i| i.new_statuses_allowed_to(user)}.

                 reduce(:&).map{|i| i.id}.include?(5)

      @request.session[:user_id] = user.id

      put(

        :update,

        :params => {

          :id => parent.id,

          :check_go_to_close_confirm => "",

          :status_id => 5

        },

        :xhr => true

      )

      assert_response :success

      assert_equal 'application/json', response.content_type

      json = ActiveSupport::JSON.decode(response.body)

      assert_equal 1, parent.reload.status.id

      assert_equal({"result" => true}, json)

      assert session.has_key?(:can_close_descendant)

      assert session[:can_close_descendant][:can_close_all]

      assert_equal [child.id, grandchild1.id], session[:can_close_descendant][:ids] 

      notes = 'close all'

      assert_difference(

        -> {parent.journals.count} => 1,

        -> {child.journals.count} => 1,

        -> {grandchild1.journals.count} => 1,

        -> {grandchild2.journals.count} => 0

      ) do

        put(

          :update,

          :params => {

            :id => parent.id,

            :close_descendants => "",

            :issue => {

              :status_id => 5,

              :notes => notes

            }

          }

        )

        assert_response 302

      end

      assert 5, parent.reload.status.id

      assert_equal notes, parent.journals.last.notes

      assert 5, child.reload.status.id

      assert_equal notes, child.journals.last.notes

      assert 5, grandchild1.reload.status.id

      assert_equal notes, grandchild1.journals.last.notes

      assert 6, grandchild2.reload.status.id

    end

  end

  test "session generated by check_go_to_close_confirm should respect subtask statuses" do

    with_settings :closed_parent_issues_with_open_subtasks => 1 do

      WorkflowTransition.delete_all

      WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,

                                 :old_status_id => 1, :new_status_id => 5)

      WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,

                                 :old_status_id => 1, :new_status_id => 6)

      WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,

                                 :old_status_id => 1, :new_status_id => 6)

      user = User.find(2)

      parent =

        Issue.

          generate!(

            :author_id => 2,

            :tracker_id => 1,

            :status_id => 1

          )

     child1 =

       Issue.

         generate!(

           :author_id => 2,

           :parent_issue_id => parent.id,

           :tracker_id => 1,

           :status_id => 1

         )

     child2 =

       Issue.

         generate!(

           :author_id => 2,

           :parent_issue_id => parent.id,

           :tracker_id => 2,

           :status_id => 1

         )

      assert parent.reload.visible?(user)

      assert child1.reload.visible?(user)

      assert child2.reload.visible?(user)

      assert [5, 6].all? do |id|

        parent.new_statuses_allowed_to(user).map{|s| s.id}.include?(id)

      end

      assert [5, 6].all? do |id|

        child1.new_statuses_allowed_to(user).map{|s| s.id}.include?(id)

      end

      assert_not child2.new_statuses_allowed_to(user).map{|s| s.id}.include?(5)

      assert child2.new_statuses_allowed_to(user).map{|s| s.id}.include?(6)

      @request.session[:user_id] = user.id

      put(

        :update,

        :params => {

          :id => parent.id,

          :check_go_to_close_confirm => "",

          :status_id => 6

        },

        :xhr => true

      )

      assert_response :success

      assert_equal 'application/json', response.content_type

      json = ActiveSupport::JSON.decode(response.body)

      assert_equal 1, parent.reload.status.id

      assert_equal({"result" => true}, json)

      assert session.has_key?(:can_close_descendant)

      assert session[:can_close_descendant][:can_close_all]

      assert_equal [child1.id, child2.id], session[:can_close_descendant][:ids] 

      @request.session.delete(:can_close_descendant)

      @request.session[:user_id] = user.id

      put(

        :update,

        :params => {

          :id => parent.id,

          :check_go_to_close_confirm => "",

          :status_id => 5

        },

        :xhr => true

      )

      assert_response :success

      assert_equal 'application/json', response.content_type

      json = ActiveSupport::JSON.decode(response.body)

      assert_equal 1, parent.reload.status.id

      assert_equal({"result" => true}, json)

      assert session.has_key?(:can_close_descendant)

      assert_not session[:can_close_descendant][:can_close_all]

      assert_not session[:can_close_descendant].has_key?(:ids)

    end

  end

  test "close all open subtasks" do

    parent = Issue.generate!(:project_id => 1)

    child = Issue.generate!(:project_id => 1, :parent_issue_id => parent.id)

    close_only_text = "Close only issue #{parent.id}"

    with_settings :closed_parent_issues_with_open_subtasks => 1 do

      log_user('dlopper', 'foo')

      visit "/issues/#{parent.id}"

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "New"})

      page.find("#issue_status_id").select("Closed")

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_no_difference 'parent.journals.count' do

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/has open subtasks/)

            assert page.has_checked_field?(close_only_text)

            page.first(:link, 'Cancel').click

          end

          assert_equal 1, parent.reload.status.id

        end

        assert_difference 'parent.journals.count' do

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            assert page.has_text?(/has open subtasks/)

            assert page.has_checked_field?(close_only_text)

            page.first(:button, 'Apply').click

          end

          assert page.has_css?('#flash_notice')

          assert_equal 5, parent.reload.status.id

        end

      end

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "Closed"})

      page.find("#issue_status_id").select("New")

      assert_no_difference ['Issue.count', 'child.journals.count'] do

        assert_difference 'parent.journals.count' do

          page.first(:button, 'Submit').click

          assert page.has_css?('#flash_notice')

          assert_equal 1, parent.reload.status.id

        end

      end

      page.first(:link, 'Edit').click

      assert page.has_select?("issue_status_id", {:selected => "New"})

      page.find("#issue_status_id").select("Closed")

      assert_no_difference 'Issue.count' do

        assert_difference ['parent.journals.count', 'child.journals.count'] do

          page.first(:button, 'Submit').click

          within('#ajax-modal') do

            all_text = 'Close all open subtasks by "Closed" status'

            assert page.has_text?(/has open subtasks/)

            assert page.has_checked_field?(close_only_text)

            page.choose(all_text)

            assert page.has_checked_field?(all_text)

            page.first(:button, 'Apply').click

          end

          assert page.has_css?('#flash_notice')

          assert_equal 5, parent.reload.status.id

          assert_equal 5, child.reload.status.id

        end

      end

    end

  end