Project

General

Profile

Defect #10721 » 10721-fixed.patch

Yuichi HARADA, 2020-05-26 04:20

View differences:

app/models/mail_handler.rb
# add To and Cc as watchers before saving so the watchers can reply to Redmine
add_watchers(issue)
issue.save!
add_attachments(issue)
issue.save!
logger&.info "MailHandler: issue ##{issue.id} created by #{user}"
issue
end
......
# add To and Cc as watchers before saving so the watchers can reply to Redmine
add_watchers(issue)
issue.save!
add_attachments(issue)
issue.save!
logger&.info "MailHandler: issue ##{issue.id} updated by #{user}"
journal
end
......
:content => cleaned_up_text_body)
reply.author = user
reply.board = message.board
message.children << reply
add_attachments(reply)
message.children << reply
reply
else
logger&.info "MailHandler: ignoring reply from [#{email.from.first}] to a locked topic"
......
email.attachments.each do |attachment|
next unless accept_attachment?(attachment)
next unless attachment.body.decoded.size > 0
obj.attachments << Attachment.create(:container => obj,
obj.saved_attachments << Attachment.create(
:file => attachment.body.decoded,
:filename => attachment.filename,
:author => user,
test/unit/mail_handler_test.rb
def test_update_issue_with_attachment
assert_difference 'Journal.count' do
assert_difference 'JournalDetail.count' do
assert_difference 'Attachment.count' do
assert_difference ->{Attachment.where(:container_type => 'Issue', :container_id => 2).count} do
assert_no_difference 'Issue.count' do
journal = submit_email('ticket_with_attachment.eml') do |raw|
raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
......
Issue.any_instance.stubs(:valid?).returns(false)
assert_no_difference 'Journal.count' do
assert_no_difference 'JournalDetail.count' do
assert_no_difference 'Attachment.count' do
assert_no_difference ->{Attachment.where(:container_type => 'Issue', :container_id => 2).count} do
assert_no_difference 'Issue.count' do
journal = submit_email('ticket_with_attachment.eml') do |raw|
raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
(3-3/3)