Add-validation-to-api-limit.patch - Redmine

Patch #16069 » Add-validation-to-api-limit.patch

Mizuki ISHIKAWA, 2020-10-26 08:08

                       Big5-HKSCS
                       TIS-620)
       MINIMUM_API_LIMIT = 100
       cattr_accessor :available_settings
       self.available_settings ||= {}
-...
             messages << [:mail_from, l('activerecord.errors.messages.invalid')]
           end
         end
         if settings.key?(:api_limit)
           if settings[:api_limit].to_i < MINIMUM_API_LIMIT
             messages << [:api_limit, l('activerecord.errors.messages.greater_than_or_equal_to', MINIMUM_API_LIMIT)]
           end
         end
         messages
       end

           end
         end
       end
       def test_api_limit_format_should_be_validated
         with_locale 'en' do
           errors = Setting.set_all_from_params({api_limit: (Setting::MINIMUM_API_LIMIT - 1).to_s})
           assert_includes errors, [:api_limit, "must be greater than or equal to #{Setting::MINIMUM_API_LIMIT}"]
           errors = Setting.set_all_from_params({api_limit: Setting::MINIMUM_API_LIMIT.to_s})
           assert_nil errors
         end
       end
     end

(6-6/6)