37187-different_errors.patch - Redmine

Defect #37187 » 37187-different_errors.patch

Felix Schäfer, 2022-06-07 11:38

       include Redmine::I18n
       class UnauthorizedAction < StandardError; end
       class NotAllowedInProject < UnauthorizedAction; end
       class InsufficientPermissions < UnauthorizedAction; end
       class MissingInformation < StandardError; end
       attr_reader :email, :user, :handler_options
-...
       # Creates a new issue
       def receive_issue
         project = target_project
         # Never receive emails to projects where adding issues is not possible
         raise NotAllowedInProject, "not possible to add issues to project [#{project.name}]" unless project.allows_to?(:add_issues)
         # check permission
         unless handler_options[:no_permission_check]
           raise UnauthorizedAction, "not allowed to add issues to project [#{project.name}]" unless user.allowed_to?(:add_issues, project)
           raise InsufficientPermissions, "not allowed to add issues to project [#{project.name}]" unless user.allowed_to?(:add_issues, project)
         end
         issue = Issue.new(:author => user, :project => project)
-...
           return nil
         end
         # Never receive emails to projects where adding issue notes is not possible
         project = issue.project
         raise NotAllowedInProject, "not possible to add notes to project [#{project.name}]" unless project.allows_to?(:add_issue_notes)
         # check permission
         unless handler_options[:no_permission_check]
           unless issue.notes_addable?
             raise UnauthorizedAction, "not allowed to add notes on issues to project [#{issue.project.name}]"
             raise InsufficientPermissions, "not allowed to add notes on issues to project [#{issue.project.name}]"
           end
         end
-...
           return nil
         end
         # Never receive emails to projects where adding messages is not possible
         project = message.project
         raise NotAllowedInProject, "not possible to add messages to project [#{project.name}]" unless project.allows_to?(:add_messages)
         unless handler_options[:no_permission_check]
           raise UnauthorizedAction, "not allowed to add messages to project [#{message.project.name}]" unless user.allowed_to?(:add_messages, message.project)
           raise InsufficientPermissions, "not allowed to add messages to project [#{message.project.name}]" unless user.allowed_to?(:add_messages, message.project)
         end
         if !message.locked?

         end
       end
       def test_no_issue_on_closed_project_without_permission_check
         Project.find(2).close
         assert_no_difference 'User.count' do
           assert_no_difference 'Issue.count' do
             submit_email(
               'ticket_by_unknown_user.eml',
               :issue => {:project => 'onlinestore'},
               :no_permission_check => '1',
               :unknown_user => 'accept'
+            )
           end
         end
       ensure
         Project.find(2).reopen
       end
       def test_no_issue_on_closed_project_without_issue_tracking_module
         assert_no_difference 'User.count' do
           assert_no_difference 'Issue.count' do
             submit_email(
               'ticket_by_unknown_user.eml',
               :issue => {:project => 'subproject2'},
               :no_permission_check => '1',
               :unknown_user => 'accept'
+            )
           end
         end
       end
       def test_add_issue_by_created_user
         Setting.default_language = 'en'
         assert_difference 'User.count' do

« Previous
1
2
Next »

(2-2/2)

Project

General

Profile

Redmine

Defect #37187 » 37187-different_errors.patch