Redmine

  def default_activity(time_entry)

    if @project

      time_entry.activity_id

    else

      TimeEntryActivity.default_activity_id(User.current, time_entry.project)

    end

  end

  belongs_to :default_time_entry_activity, :class_name => "TimeEntryActivity"

    'permissions_tracker_ids',

    'default_time_entry_activity_id'

      self.activity_id = TimeEntryActivity.default_activity_id(User.current, self.project)

  # Returns the available activities for the time entry

  def self.default_activity_id(user=nil, project=nil)

    default_activities = []

    default_activity = nil

    available_activities = self.available_activities(project)

    if project && user

      user_membership = user.membership(project)

      if user_membership

        default_activities = user_membership.roles.where.not(:default_time_entry_activity_id => nil).sort.pluck(:default_time_entry_activity_id)

      end

      project_default_activity = self.default(project)

      if project_default_activity

        default_activities << project_default_activity.id unless default_activities.include?(project_default_activity.id)

      end

    end

    global_activity = self.default

    if global_activity

      default_activities << global_activity.id unless default_activities.include?(global_activity.id)

    end

    if available_activities.count == 1

      default_activities << available_activities.first.id unless default_activities.include?(available_activities.first.id)

    end

    default_activities.each do |id|

      default_activity = available_activities.detect{ |a| a.id == id || a.parent_id == id }

      break unless default_activity.nil?

    end

    default_activity.id unless default_activity.nil?

  end

  <% unless @role.anonymous? %>

    <p><%= f.select :default_time_entry_activity_id, options_from_collection_for_select(TimeEntryActivity.active.shared, :id, :name, @role.default_time_entry_activity_id), :include_blank => l(:label_none) %></p>

  <% end %>

$('#time_entry_activity_id').html('<%= escape_javascript options_for_select(activity_collection_for_select_options(@time_entry), default_activity(@time_entry)) %>');

class AddDefaultTimeEntryActivityToRoles < ActiveRecord::Migration[5.2]

  def change

    add_column :roles, :default_time_entry_activity_id, :int

  end

end

  def test_new_should_select_default_role_activity

    developer = Role.find(2)

    developer.default_time_entry_activity_id = 9

    developer.save!

    @request.session[:user_id] = 3

    get :new, :params => {:project_id => 1}

    assert_response :success

    assert_select 'select[name=?]', 'time_entry[activity_id]' do

      assert_select 'option[selected=selected]', :text => 'Design'

    end

  end

  def test_new_should_select_default_global_activity_for_user_roles_without_default_activities

  def test_default_activity_id_without_user_and_project_should_return_global_default_activity

    assert_equal 10, TimeEntryActivity.default_activity_id

  end

  def test_default_activity_id_with_user_and_project_should_return_role_default_activity

    # set a default activity for Manager role

    manager = Role.find(1)

    manager.default_time_entry_activity_id = 9

    manager.save

    assert_equal 9, TimeEntryActivity.default_activity_id(User.find(2), Project.find(1))

  end

  def test_default_activity_id_with_user_and_project_should_consider_role_position

    project = Project.find(1)

    user = User.find(2)

    # set a default activity for Manager role

    manager = Role.find(1)

    manager.default_time_entry_activity_id = 9

    manager.save!

    # set a default activity for Developer role

    # and set the role position first

    developer = Role.find(2)

    developer.default_time_entry_activity_id = 11

    developer.position = 1

    developer.save!

    member = Member.find_or_initialize_by(:project_id => project.id, :user_id => user.id)

    member.role_ids = [1, 2]

    member.save!

    assert_equal 11, TimeEntryActivity.default_activity_id(user, project)

  end

  def test_default_activity_id_should_include_only_available_activities

    # set a default activity for Manager role

    manager = Role.find(1)

    manager.default_time_entry_activity_id = 9

    manager.save!

    project = Project.find(1)

    # disable role default activity

    disable_activity = TimeEntryActivity.new({:name => "QA", :project => project, :parent => TimeEntryActivity.find(9), :active => false})

    disable_activity.save!

    assert_equal 10, TimeEntryActivity.default_activity_id(User.find(2), project)

  end

  def test_default_activity_id_should_selected_from_highest_priority_of_multiple_default_activity_candidates

    project = Project.find(1)

    manager = Role.find(1)

    manager.default_time_entry_activity_id = 9

    manager.save

    # Returns the role_default_activity with the highest priority

    assert_equal 9, TimeEntryActivity.default_activity_id(User.find(2), project)

    # Returns the child activity of role_default_activity if there is an activity that has the id of role_default_activity as parent_id

    design_project_activity = TimeEntryActivity.create!(name: 'Design', parent_id: 9, project_id: project.id, is_default: false)

    development_project_activity = TimeEntryActivity.create!(name: 'Development', parent_id: 10, project_id: project.id, is_default: true)

    qa_project_activity = TimeEntryActivity.create!(name: 'QA', parent_id: 11, project_id: project.id, is_default: false)

    assert_equal design_project_activity.id, TimeEntryActivity.default_activity_id(User.find(2), project)

    # Returns default project activity if role_default_activity is not present

    manager.default_time_entry_activity_id = nil

    manager.save

    assert_equal development_project_activity.id, TimeEntryActivity.default_activity_id(User.find(2), project)

    # Returns global default activity if role_default_activity and project activities are not present

    [design_project_activity, development_project_activity, qa_project_activity].each {|activity| activity.destroy}

    TimeEntryActivity.find(11).update(is_default: true)

    assert_equal 11, TimeEntryActivity.default_activity_id(User.find(2), project)

    # If there is only one activity available, it returns that activity.

    [TimeEntryActivity.find(10), TimeEntryActivity.find(11)].each {|a| a.update(active: false)}

    assert_equal 9, TimeEntryActivity.default_activity_id(User.find(2), project)

  end