Defect #37635 » 0001-Consider-only-roles-with-either-add_issues-or-edit_i.patch
| app/models/issue.rb | ||
|---|---|---|
|
def workflow_rule_by_attribute(user=nil)
|
||
|
return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
|
||
|
user_real = user || User.current
|
||
|
roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
|
||
|
roles = roles.select(&:consider_workflow?)
|
||
|
roles = roles_for_workflow(user || User.current)
|
||
|
return {} if roles.empty?
|
||
|
result = {}
|
||
| ... | ... | |
|
statuses = []
|
||
|
statuses += IssueStatus.new_statuses_allowed(
|
||
|
initial_status,
|
||
|
user.admin ? Role.all.to_a : user.roles_for_project(project),
|
||
|
roles_for_workflow(user),
|
||
|
tracker,
|
||
|
author == user,
|
||
|
assignee_transitions_allowed
|
||
| ... | ... | |
|
Project
|
||
|
end
|
||
|
end
|
||
|
def roles_for_workflow(user)
|
||
|
roles = user.admin ? Role.all.to_a : user.roles_for_project(project)
|
||
|
roles.select(&:consider_workflow?)
|
||
|
end
|
||
|
end
|
||
| test/unit/issue_test.rb | ||
|---|---|---|
|
assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
|
||
|
end
|
||
|
def test_new_statuses_allowed_to_should_only_return_transitions_of_considered_workflows
|
||
|
issue = Issue.find(9)
|
||
|
WorkflowTransition.delete_all
|
||
|
WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
|
||
|
developer = Role.find(2)
|
||
|
developer.remove_permission! :edit_issues
|
||
|
developer.remove_permission! :add_issues
|
||
|
assert !developer.consider_workflow?
|
||
|
WorkflowTransition.create!(:role_id => 2, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
|
||
|
# status 3 is not displayed
|
||
|
expected_statuses = IssueStatus.where(:id => [1, 2])
|
||
|
admin = User.find(1)
|
||
|
assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
|
||
|
author = User.find(8)
|
||
|
assert_equal expected_statuses, issue.new_statuses_allowed_to(author)
|
||
|
end
|
||
|
def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
|
||
|
Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
|
||
- « Previous
- 1
- 2
- Next »