Project

General

Profile

Feature #38238 » 38238-3_no_anonymous_watcher.patch

Felix Schäfer, 2023-02-11 21:42

View differences:

app/models/issue.rb
end
def add_auto_watcher
if author &&
author.allowed_to?(:add_issue_watchers, project) &&
if author&.active? &&
author&.allowed_to?(:add_issue_watchers, project) &&
author.pref.auto_watch_on?('issue_created') &&
self.watcher_user_ids.exclude?(author.id)
self.set_watcher(author, true)
app/models/journal.rb
end
def add_watcher
if user &&
user.allowed_to?(:add_issue_watchers, project) &&
if user&.active? &&
user&.allowed_to?(:add_issue_watchers, project) &&
user.pref.auto_watch_on?('issue_contributed_to') &&
!Watcher.any_watched?(Array.wrap(journalized), user)
journalized.set_watcher(user, true)
test/unit/issue_test.rb
end
end
def test_create_should_not_add_anonymous_as_watcher
Role.anonymous.add_permission!(:add_issue_watchers)
user = User.anonymous
assert user.pref.auto_watch_on?('issue_contributed_to')
journal = Journal.new(:journalized => Issue.first, :notes => 'notes', :user => user)
assert_no_difference 'Watcher.count' do
assert journal.save
assert journal.valid?
assert journal.journalized.valid?
end
end
def test_like_should_escape_query
issue = Issue.generate!(:subject => "asdf")
r = Issue.like('as_f')
test/unit/journal_test.rb
end
end
def test_create_should_not_add_anonymous_as_watcher
Role.anonymous.add_permission!(:add_issue_watchers)
user = User.anonymous
assert user.pref.auto_watch_on?('issue_contributed_to')
journal = Journal.new(:journalized => Issue.first, :notes => 'notes', :user => user)
assert_no_difference 'Watcher.count' do
assert journal.save
assert journal.valid?
assert journal.journalized.valid?
end
end
def test_visible_scope_for_anonymous
# Anonymous user should see issues of public projects only
journals = Journal.visible(User.anonymous).to_a
(3-3/4)