Project

General

Profile

Defect #38966 » fix-38966-remove_attachment_after_custom_value_deleted.patch

Takenori TAKAKI, 2023-09-07 08:09

View differences:

lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
return if self.included_modules.include?(Redmine::Acts::Customizable::InstanceMethods)
cattr_accessor :customizable_options
self.customizable_options = options
before_destroy :preserve_custom_field_attachment_data
has_many :custom_values, lambda {includes(:custom_field)},
:as => :customized,
:inverse_of => :customized,
......
send :include, Redmine::Acts::Customizable::InstanceMethods
validate :validate_custom_field_values
after_save :save_custom_field_values
after_destroy :destroy_custom_field_attachments
end
end
......
super
end
def preserve_custom_field_attachment_data
@custom_field_attachment_data = self.custom_values.select{ |cv| cv.custom_field.field_format == 'attachment'}.map(&:id)
end
def destroy_custom_field_attachments
@custom_field_attachment_data.each do |container_id|
Attachment.where(:container_id => container_id, :container_type => 'CustomValue').destroy_all
end
end
module ClassMethods
end
end
test/unit/issue_test.rb
end
end
def test_destroy_should_delete_attachments_on_custom_values
cf = IssueCustomField.create!(:name => 'Attachable field', :field_format => 'attachment', :is_for_all => true, :tracker_ids => [1])
user = User.find(2)
issue = Issue.new(:project_id => 1, :tracker_id => 1, :subject => 'test', :author_id => user.id)
attachment = Attachment.create!(:container => issue,:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => user.id)
issue.send(
:safe_attributes=,
{
'custom_fields' =>
[
{'id' => cf.id.to_s, 'value' => attachment.id.to_s},
]
}, user
)
assert_difference 'CustomValue.where(:customized_type => "Issue").count', -(issue.custom_values.count) do
assert_difference 'Attachment.count', -1 do
issue.destroy
end
end
end
def test_destroying_a_deleted_issue_should_not_raise_an_error
issue = Issue.find(1)
Issue.find(1).destroy
(2-2/4)