Project

General

Profile

Defect #39862 » 0001-dynamic-object_type-routing-constraint-39862.patch

Jens Krämer, 2023-12-18 06:40

View differences:

config/routes.rb
get 'attachments/download/:id', :to => 'attachments#download', :id => /\d+/
get 'attachments/thumbnail/:id(/:size)', :to => 'attachments#thumbnail', :id => /\d+/, :size => /\d+/, :as => 'thumbnail'
resources :attachments, :only => [:show, :update, :destroy]
constraints object_type: /(issues|versions|news|messages|wiki_pages|projects|documents|journals)/ do
# register plugin object types with ObjectTypeConstraint.register_object_type(PluginModel.name.underscore.pluralize')
constraints Redmine::Acts::Attachable::ObjectTypeConstraint do
get 'attachments/:object_type/:object_id/edit', :to => 'attachments#edit_all', :as => :object_attachments_edit
patch 'attachments/:object_type/:object_id', :to => 'attachments#update_all', :as => :object_attachments
get 'attachments/:object_type/:object_id/download', :to => 'attachments#download_all', :as => :object_attachments_download
lib/plugins/acts_as_attachable/lib/acts_as_attachable.rb
module Redmine
module Acts
module Attachable
class ObjectTypeConstraint
cattr_accessor :object_types
self.object_types = Concurrent::Set.new(%w[
issues versions news messages wiki_pages projects documents journals
])
class << self
def matches?(request)
request.path_parameters[:object_type] =~ param_expression
end
def register_object_type(type)
object_types << type
@param_expression = nil
end
def param_expression
@param_expression ||= Regexp.new("^(#{object_types.join("|")})$")
end
end
end
def self.included(base)
base.extend ClassMethods
end
test/fixtures/plugins/redmine_test_plugin_foo/init.rb
version '0.0.1'
end
Redmine::Acts::Attachable::ObjectTypeConstraint.register_object_type('plugin_articles')
Pathname(__dir__).glob("app/**/*.rb").sort.each do |path|
require path
end
test/integration/routing/plugins_test.rb
should_route 'GET /plugin_articles' => 'plugin_articles#index'
should_route 'GET /bar_plugin_articles' => 'bar_plugin_articles#index'
assert_equal("/bar_plugin_articles", plugin_articles_path)
should_route(
'GET /attachments/plugin_articles/12/edit' => 'attachments#edit_all',
object_id: '12',
object_type: 'plugin_articles'
)
end
end
    (1-1/1)