Project

General

Profile

Defect #38966 » 38966-v3.patch

Go MAEDA, 2024-10-22 11:59

View differences:

db/migrate/20241022095140_remove_orphaned_custom_value_attachments.rb
class RemoveOrphanedCustomValueAttachments < ActiveRecord::Migration[7.2]
def up
Attachment.where(container_type: 'CustomValue')
.where('NOT EXISTS (SELECT 1 FROM custom_values WHERE custom_values.id = attachments.container_id)')
.destroy_all
end
def down
# no-op
end
end
lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
return if self.included_modules.include?(Redmine::Acts::Customizable::InstanceMethods)
cattr_accessor :customizable_options
self.customizable_options = options
before_destroy :store_attachment_custom_value_ids
has_many :custom_values, lambda {includes(:custom_field)},
:as => :customized,
:inverse_of => :customized,
......
send :include, Redmine::Acts::Customizable::InstanceMethods
validate :validate_custom_field_values
after_save :save_custom_field_values
after_destroy :destroy_custom_value_attachments
end
end
......
super
end
def store_attachment_custom_value_ids
@attachment_custom_value_ids =
custom_values.select {|cv| cv.custom_field.field_format == 'attachment'}
.map(&:id)
end
def destroy_custom_value_attachments
Attachment.where(:container_id => @attachment_custom_value_ids, :container_type => 'CustomValue')
.destroy_all
end
module ClassMethods
end
end
test/unit/issue_test.rb
end
end
def test_destroy_should_delete_attachments_on_custom_values
cf = IssueCustomField.create!(:name => 'Attachable field', :field_format => 'attachment', :is_for_all => true, :tracker_ids => [1])
user = User.find(2)
issue = Issue.new(:project_id => 1, :tracker_id => 1, :subject => 'test', :author_id => user.id)
attachment = Attachment.create!(:container => issue,:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => user.id)
issue.send(
:safe_attributes=,
{
'custom_fields' =>
[
{'id' => cf.id.to_s, 'value' => attachment.id.to_s},
]
}, user
)
assert_difference 'CustomValue.where(:customized_type => "Issue").count', -(issue.custom_values.count) do
assert_difference 'Attachment.count', -1 do
issue.destroy
end
end
end
def test_destroying_a_deleted_issue_should_not_raise_an_error
issue = Issue.find(1)
Issue.find(1).destroy
(4-4/4)