Project

General

Profile

Feature #42630 » 0003-Use-visible-for-method-names-for-consistency.patch

Katsuya HIDAKA, 2025-05-15 03:30

View differences:

app/helpers/reactions_helper.rb
DISPLAY_REACTION_USERS_LIMIT = 10
def reaction_button(object)
return unless Redmine::Reaction.viewable?(object, User.current)
return unless Redmine::Reaction.visible?(object, User.current)
detail = object.reaction_detail
lib/redmine/reaction.rb
REACTABLE_TYPES = %w(Journal Issue Message News Comment)
# Returns true if the user can view the reaction of the object
def self.viewable?(object, user = User.current)
def self.visible?(object, user = User.current)
Setting.reactions_enabled? && object.visible?(user)
end
# Returns true if the user can add/remove a reaction to/from the object
def self.editable?(object, user = User.current)
user.logged? && viewable?(object, user) && object&.project&.active?
user.logged? && visible?(object, user) && object&.project&.active?
end
module Reactable
test/unit/lib/redmine/reaction_test.rb
), comment1.reaction_detail
end
test 'viewable? returns true when reactions are enabled and object is visible to user' do
test 'visible? returns true when reactions are enabled and object is visible to user' do
object = issues(:issues_007)
user = users(:users_002)
assert Redmine::Reaction.viewable?(object, user)
assert Redmine::Reaction.visible?(object, user)
end
test 'viewable? returns false when reactions are disabled' do
test 'visible? returns false when reactions are disabled' do
Setting.reactions_enabled = '0'
object = issues(:issues_007)
user = users(:users_002)
assert_not Redmine::Reaction.viewable?(object, user)
assert_not Redmine::Reaction.visible?(object, user)
end
test 'viewable? returns false when object is not visible to user' do
test 'visible? returns false when object is not visible to user' do
object = issues(:issues_007)
user = users(:users_002)
object.expects(:visible?).with(user).returns(false)
assert_not Redmine::Reaction.viewable?(object, user)
assert_not Redmine::Reaction.visible?(object, user)
end
test 'editable? returns true for various reactable objects when user is logged in, object is visible, and project is active' do
(21-21/30)