0001-WIP.patch - Redmine

       def update
         return unless update_issue_from_params
         if params[:sourcepos].present?
           source_pos = params[:sourcepos] # e.g., "10:1-10:15"
           is_checked = params[:checked]
           line_number = source_pos.split(':').first.to_i
           description_lines = @issue.description.lines
           target_line = description_lines[line_number - 1]
           if target_line
             if is_checked
               # Change '[ ]' to '[x]'
               target_line.sub!(/\[\s\]/, '[x]')
             else
               # Change '[x]' to '[ ]'
               target_line.sub!(/\[x\]/i, '[ ]')
             end
           end
           @issue.description = description_lines.join
         end
         # if params[:source]
         attachments = params[:attachments] || params.dig(:issue, :uploads)
         if @issue.attachments_addable?
           @issue.save_attachments(attachments)

     import {Controller} from '@hotwired/stimulus'
     export default class extends Controller {
         // Define the 'updateUrl' value that we passed from the HTML
         static values = {
             id: String,
         };
         connect() {
             // Find all checkboxes within this controller's scope and enable them.
             this.element.querySelectorAll('input[type="checkbox"].task-list-item-checkbox').forEach(checkbox => {
                 checkbox.disabled = false;
                 checkbox.addEventListener('change', (event) => {
                     const isChecked = event.target.checked;
                     const sourcePosition = checkbox.parentElement.dataset.sourcepos;
                     if (!sourcePosition) {
                         console.error('Task item is missing data-sourcepos attribute.');
                         // Optionally revert the checkbox and show an error
                         event.target.checked = !isChecked;
                         return;
+                    }
                     this.updateTaskListItem(this.idValue, sourcePosition, isChecked);
                 });
             });
+        }
         async updateTaskListItem(issueId, sourcePosition, isChecked) {
             // You need to get the CSRF token for Rails
             const csrfToken = document.querySelector('meta[name="csrf-token"]')?.content;
             try {
                 const response = await fetch(`/issues/${issueId}`, {
                     method: 'PATCH',
                     headers: {
                         'Content-Type': 'application/json',
                         'Accept': 'application/json',
                         'X-CSRF-Token': csrfToken,
                     },
                     body: JSON.stringify({
                         sourcepos: sourcePosition,
                         checked: isChecked,
                     }),
                 });
                 if (!response.ok) {
                     // Handle server error: revert the checkbox state and alert the user
                     throw new Error();
+                }
                 console.log('Task updated successfully!');
             } catch (error) {
                 console.error('Error:', error);
                 // Revert the checkbox state
+            }
+        }
+    }

       </div>
       <p><strong><%=l(:field_description)%></strong></p>
       <div id="issue_description_wiki" class="wiki" data-quote-reply-target="content">
       <div id="issue_description_wiki" class="wiki"
            data-quote-reply-target="content"
            data-controller="task-list"
            data-task-list-id-value="<%= @issue.id %>">
       <%= textilizable @issue, :description, :attachments => @issue.attachments %>
       </div>
     </div>

lib/redmine/wiki_formatting/common_mark/formatter.rb
47	47	github_pre_lang: false,
48	48	hardbreaks: Redmine::Configuration['common_mark_enable_hardbreaks'] == true,
49	49	tasklist_classes: true,
	50	sourcepos: true,
50	51	}.freeze,
51	52	commonmarker_plugins: {
52	53	syntax_highlighter: nil

             def call
               html = Commonmarker.to_html(@text, options: {
                                             extension: extensions,
                 extension: extensions,
                 render: render_options,
                 parse: parse_options
                                           }, plugins: plugins)
               }, plugins: plugins)
               html.rstrip!
               html

               # allow `id` in li element for footnotes
               # allow `class` in li element for task list items
               allowlist[:attributes]["li"] = %w(id class)
               allowlist[:attributes]["li"] = %w(id class data-sourcepos)
               allowlist[:transformers].push lambda{|env|
                 node = env[:node]
                 return unless node.name == "li"

Project

General

Profile

Redmine

Feature #39130 » 0001-WIP.patch