Project

General

Profile

Download (5.16 KB)

Defect #43714 ยป 0001-Fix-misleading-arrow-buttons-for-Available-Selected-.patch

Go MAEDA, 2026-01-25 09:48

View differences:

app/assets/images/icons.svg
66 66 
      <path d="M14 7l6 0"/>
67 67 
      <path d="M17 4l0 6"/>
68 68 
    </symbol>
69 
    <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--arrow-narrow-left">
70 
      <path d="M5 12l14 0"/>
71 
      <path d="M5 12l4 4"/>
72 
      <path d="M5 12l4 -4"/>
73 
    </symbol>
74 
    <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--arrow-narrow-right">
75 
      <path d="M5 12l14 0"/>
76 
      <path d="M15 16l4 -4"/>
77 
      <path d="M15 8l4 4"/>
78 
    </symbol>
69 79 
    <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--arrow-right">
70 80 
      <path d="M4 9h8v-3.586a1 1 0 0 1 1.707 -.707l6.586 6.586a1 1 0 0 1 0 1.414l-6.586 6.586a1 1 0 0 1 -1.707 -.707v-3.586h-8a1 1 0 0 1 -1 -1v-4a1 1 0 0 1 1 -1z"/>
71 81 
    </symbol>
app/assets/stylesheets/application.css
621 621 
.query-columns label {
622 622 
  display:block;
623 623 
}
624 
#list-definition .buttons input[type=button] {
624 
#list-definition .buttons button {
625 625 
  inline-size:35px;
626 626 
  display:block;
627 627 
}
app/views/queries/_columns.html.erb
11 11 
              :ondblclick => "moveOptions(this.form.#{available_tag_id}, this.form.#{selected_tag_id});" %>
12 12 
</div>
13 13 
<div class="buttons">
14 
      <input type="button" value="&#8594;" class="move-right"
15 
       onclick="moveOptions(this.form.<%= available_tag_id %>, this.form.<%= selected_tag_id %>);" />
16 
      <input type="button" value="&#8592;" class="move-left"
17 
       onclick="moveOptions(this.form.<%= selected_tag_id %>, this.form.<%= available_tag_id %>);" />
14 
      <button type="button" class="move-right" onclick="moveOptions(this.form.<%= available_tag_id %>, this.form.<%= selected_tag_id %>);"><%= sprite_icon("arrow-narrow-right", rtl: true) %></button>
15 
      <button type="button" class="move-left" onclick="moveOptions(this.form.<%= selected_tag_id %>, this.form.<%= available_tag_id %>);"><%= sprite_icon("arrow-narrow-left", rtl: true) %></button>
18 16 
</div>
19 17 
<div class="query-columns">
20 18 
      <%= label_tag selected_tag_id, l(:description_selected_columns) %>
......
25 23 
              :ondblclick => "moveOptions(this.form.#{selected_tag_id}, this.form.#{available_tag_id});" %>
26 24 
</div>
27 25 
<div class="buttons">
28 
      <input type="button" value="&#8648;" onclick="moveOptionTop(this.form.<%= selected_tag_id %>);" />
29 
      <input type="button" value="&#8593;" onclick="moveOptionUp(this.form.<%= selected_tag_id %>);" />
30 
      <input type="button" value="&#8595;" onclick="moveOptionDown(this.form.<%= selected_tag_id %>);" />
31 
      <input type="button" value="&#8650;" onclick="moveOptionBottom(this.form.<%= selected_tag_id %>);" />
26 
      <button type="button" onclick="moveOptionTop(this.form.<%= selected_tag_id %>);">&#8648;</button>
27 
      <button type="button" onclick="moveOptionUp(this.form.<%= selected_tag_id %>);">&#8593;</button>
28 
      <button type="button" onclick="moveOptionDown(this.form.<%= selected_tag_id %>);">&#8595;</button>
29 
      <button type="button" onclick="moveOptionBottom(this.form.<%= selected_tag_id %>);">&#8650;</button>
32 30 
</div>
33 31 

  		




  34
  32
  
    
<%= javascript_tag do %>

  		












  

    
      config/icon_source.yml
    
  





  248
  248
  
    
  svg: apps

  		




  249
  249
  
    
- name: shield-check

  		




  250
  250
  
    
  svg: shield-check

  		




  
  251
  
    
- name: arrow-narrow-left

  		




  
  252
  
    
  svg: arrow-narrow-left

  		




  
  253
  
    
- name: arrow-narrow-right

  		




  
  254
  
    
  svg: arrow-narrow-right

  		












  

    
      test/system/timelog_test.rb
    
  





  86
  86
  
    
    visit '/settings?tab=timelog'

  		




  87
  87
  
    
    # Remove a column

  		




  88
  88
  
    
    select 'Comment', :from => 'Selected Columns'

  		




  89
  
  
    
    page.first('input[type=button].move-left').click

  		




  
  89
  
    
    page.first('button.move-left').click

  		




  90
  90
  
    
    # Add a column

  		




  91
  91
  
    
    select 'Tracker', :from => 'Available Columns'

  		




  92
  
  
    
    page.first('input[type=button].move-right').click

  		




  
  92
  
    
    page.first('button.move-right').click

  		




  93
  93
  
    
    click_on 'Save'

  		




  94
  94
  
    
    assert_text 'Successful update.'

  		




  95
  95
  
    

  		















  
    (1-1/1)