0001-Add-tracker-setting-for-private-issues-by-default.patch - Redmine

           # so we can use the default version for the new project
           attrs.delete(:fixed_version_id)
         end
         if action_name == 'new' &&
              %w[issue_project_id issue_tracker_id].include?(params[:form_update_triggered_by]) &&
              attrs[:is_private] != '1'
           # Drop the unchecked value so the selected tracker's private default can be applied.
           attrs.delete(:is_private)
         end
         attrs[:assigned_to_id] = User.current.id if attrs[:assigned_to_id] == 'me'
         @issue.safe_attributes = attrs

         if new_record? && !statuses_allowed.include?(status)
           self.status = statuses_allowed.first || default_status
         end
         # Use the selected tracker's private default when the form has no explicit value.
         if new_record? && tracker&.private_by_default? &&
              !attrs.key?('is_private') && safe_attribute?('is_private', user)
           attrs['is_private'] = '1'
         end
         if (u = attrs.delete('assigned_to_id')) && safe_attribute?('assigned_to_id')
           self.assigned_to_id = u
         end

app/models/tracker.rb
74	74	'name',
75	75	'default_status_id',
76	76	'is_in_roadmap',
	77	'private_by_default',
77	78	'core_fields',
78	79	'position',
79	80	'custom_field_ids',

app/views/trackers/_form.html.erb
10	10	:include_blank => @tracker.default_status.nil?,
11	11	:required => true %>
12	12	</p>
	13	<p><%= f.check_box :private_by_default %></p>
13	14	<p><%= f.check_box :is_in_roadmap %></p>
14	15	<p><%= f.textarea :description, :rows => 4 %></p>
15	16	<p>

config/locales/en.yml
326	326	field_is_public: Public
327	327	field_parent: Subproject of
328	328	field_is_in_roadmap: Issues displayed in roadmap
	329	field_private_by_default: Private by default
329	330	field_login: Login
330	331	field_mail_notification: Email notifications
331	332	field_admin: Administrator

db/migrate/20260510000000_add_private_by_default_to_trackers.rb
	1	class AddPrivateByDefaultToTrackers < ActiveRecord::Migration[8.1]
	2	def change
	3	add_column :trackers, :private_by_default, :boolean, :default => false, :null => false
	4	end
	5	end

         end
       end
       def test_new_should_check_private_if_tracker_is_private_by_default
         Tracker.find(1).update! :private_by_default => true
         @request.session[:user_id] = 2
         get(:new, :params => {:project_id => 1})
         assert_response :success
         assert_select 'input[name=?][checked=checked]', 'issue[is_private]'
       end
       def test_update_form_for_new_issue_should_apply_private_by_default_when_submitted_private_is_unchecked
         Tracker.find(2).update! :private_by_default => true
         @request.session[:user_id] = 2
         # Simulates switching from an unchecked tracker to a tracker that is private by default.
         post(
           :new,
           :params => {
             :project_id => 1,
             :issue => {
               :tracker_id => 2,
               :is_private => '0'
             },
             :form_update_triggered_by => 'issue_tracker_id'
+          }
+        )
         assert_response :success
         assert_select 'select[name=?]', 'issue[tracker_id]' do
           assert_select 'option[value=?][selected=selected]', '2'
         end
         assert_select 'input[name=?][checked=checked]', 'issue[is_private]'
       end
       def test_update_form_for_new_issue_should_keep_submitted_private_when_checked
         @request.session[:user_id] = 2
         # Simulates keeping the user's checked private value when switching trackers.
         post(
           :new,
           :params => {
             :project_id => 1,
             :issue => {
               :tracker_id => 2,
               :is_private => '1'
             },
             :form_update_triggered_by => 'issue_tracker_id'
+          }
+        )
         assert_response :success
         assert_select 'select[name=?]', 'issue[tracker_id]' do
           assert_select 'option[value=?][selected=selected]', '2'
         end
         assert_select 'input[name=?][checked=checked]', 'issue[is_private]'
       end
       def test_update_form_for_new_issue_should_ignore_version_when_changing_project
         version = Version.generate!(:project_id => 1)
         Project.find(1).update_attribute :default_version_id, version.id
-...
         assert issue.is_private?
       end
       def test_post_create_should_respect_private_by_default_per_tracker_setting
         @request.session[:user_id] = 2
         tracker = Tracker.find(1)
         tracker.update! :private_by_default => true
         assert_difference 'Issue.count' do
           post(
             :create,
             :params => {
               :project_id => 1,
               :issue => {
                 :tracker_id => tracker.id,
                 :subject => 'This is a private issue by default'
+              }
+            }
+          )
         end
         issue = Issue.order(id: :desc).first
         assert issue.is_private?
         assert_difference 'Issue.count' do
           post(
             :create,
             :params => {
               :project_id => 1,
               :issue => {
                 :tracker_id => tracker.id,
                 :subject => 'This is a public issue',
                 :is_private => '0'
+              }
+            }
+          )
         end
         issue = Issue.order(id: :desc).first
         assert_not issue.is_private?
       end
       def test_post_create_should_not_apply_private_by_default_without_permission
         role = Role.find(1)
         role.remove_permission! :set_issues_private
         role.remove_permission! :set_own_issues_private
         Tracker.find(1).update! :private_by_default => true
         @request.session[:user_id] = 2
         assert_difference 'Issue.count' do
           post(
             :create,
             :params => {
               :project_id => 1,
               :issue => {
                 :tracker_id => 1,
                 :subject => 'This is a public issue'
+              }
+            }
+          )
         end
         issue = Issue.order(id: :desc).first
         assert_not issue.is_private?
       end
       def test_create_without_project_id
         @request.session[:user_id] = 2
         assert_difference 'Issue.count' do

             :tracker => {
               :name => 'New tracker',
               :default_status_id => 1,
               :private_by_default => '1',
               :project_ids => ['1', '', ''],
               :custom_field_ids => ['1', '6', '']
+            }
-...
         assert_redirected_to :action => 'index'
         tracker = Tracker.order(id: :desc).first
         assert_equal 'New tracker', tracker.name
         assert tracker.private_by_default?
         assert_equal [1], tracker.project_ids.sort
         assert_equal Tracker::CORE_FIELDS, tracker.core_fields
         assert_equal [1, 6], tracker.custom_field_ids.sort

         assert_response :unprocessable_content
       end
       test "POST /issues.json should use the tracker private_by_default setting" do
         Tracker.find(1).update! :private_by_default => true
         issue = new_record(Issue) do
           post(
             '/issues.json',
             :params => {:issue => {:project_id => 1, :tracker_id => 1, :subject => 'API'}},
             :headers => credentials('jsmith'))
         end
         assert issue.is_private?
       end
       test "PUT /issues/:id.xml" do
         assert_difference('Journal.count') do
           put(

Project

General

Profile

Redmine

Feature #9432 » 0001-Add-tracker-setting-for-private-issues-by-default.patch