0001-Fix-broken-links-to-headings-containing-quotes.patch - Redmine

Defect #44718 » 0001-Fix-broken-links-to-headings-containing-quotes.patch

Katsuya HIDAKA, 2026-11-05 06:45

         text.gsub!(HEADING_RE) do
           level, attrs, content = $2.to_i, $3, $4
           item = strip_tags(content).strip
           # Remove HTML tags using the same sanitizer as strip_tags, without escaping quotes.
           # Keep quotes literal so sanitize_anchor_name removes them rather than leaving
           # parts of HTML entities in the anchor (e.g. &#39; becoming 39).
           item = self.class.full_sanitizer.sanitize(content).strip
           anchor = sanitize_anchor_name(item)
           # used for single-file wiki export
           if options[:wiki_links] == :anchor && (obj.is_a?(WikiContent) ||
-...
           if idx > 1
             anchor = "#{anchor}-#{idx}"
           end
           @parsed_headings << [level, anchor, item]
           @parsed_headings << [level, anchor, ERB::Util.html_escape_once(item)]
           "<a name=\"#{anchor}\"></a>\n<h#{level} #{attrs}>#{content}" \
             "<a href=\"##{anchor}\" class=\"wiki-anchor\">&para;</a></h#{level}>"
         end

       end
       def test_headings_with_special_chars
         # This test makes sure that the generated anchor names match the expected
         # ones even if the heading text contains unconventional characters
         raw = 'h1. Some heading related to version 0.5'
         anchor = sanitize_anchor_name("Some-heading-related-to-version-0.5")
         expected =
           %|<a name="#{anchor}"></a>\n<h1 >Some heading related to version 0.5| +
             %|<a href="##{anchor}" class="wiki-anchor">&para;</a></h1>|
         with_settings :text_formatting => 'textile' do
           assert_equal expected, textilizable(raw)
         # Each value is [expected anchor name, expected HTML-escaped TOC text].
         headings = {
           'Some heading related to version 0.5' =>
             ['Some-heading-related-to-version-05', 'Some heading related to version 0.5'],
           "Bob's guide" => ['Bobs-guide', 'Bob&#39;s guide'],
           'The "quoted" guide' => ['The-quoted-guide', 'The &quot;quoted&quot; guide'],
           "*Bob's* & B" => ['Bobs-amp-B', 'Bob&#39;s &amp; B'],
           '&lt;img src=x onerror=alert(1)&gt;' =>
             ['ltimg-srcx-onerroralert1gt', '&lt;img src=x onerror=alert(1)&gt;']
+        }
         {'textile' => 'h1.', 'common_mark' => '#'}.each do |format, prefix|
           with_settings :text_formatting => format do
             headings.each do |heading, (anchor, escaped_heading)|
               raw = "{{toc}}\n\n#{prefix} #{heading}\n\n[[##{anchor}|Wiki link]]"
               html = textilizable(raw)
               assert_select_in html, 'a[name=?]', anchor, :count => 1
               assert_select_in html, 'h1 a.wiki-anchor[href=?]', "##{anchor}", :count => 1
               assert_include %(<a href="##{anchor}">#{escaped_heading}</a>), html
               assert_select_in html, 'a.wiki-page[href=?]', "##{anchor}", :text => 'Wiki link'
             end
           end
         end
       end

(1-1/1)

Project

General

Profile

Redmine

Defect #44718 » 0001-Fix-broken-links-to-headings-containing-quotes.patch