Time & Expense 1.6

Added by Dhanasingh Krishnapandian about 4 years ago

We are happy to announce the release of Time & Expense plugin version 1.6
Please download it from http://www.redmine.org/plugins/wk-time

Features:
- Supports REST Api
- Separate Permission for Approving Time Logs
- Filter timesheets by groups
- Filter Issues assigned to me
- Configure Public Holidays
- Support for MS SQL Server
- User with View Spent time permission can only see the list page.
Bugs:
- wrap Settings object within Rails.configuration.to_prepare inside init.rb
- Show the message “no users in the selected project" in new time/expense sheet
- Expense report link does not shows up by default
- Allow 0 for time/expense entry

Resources:

User guide:
http://www.adhisoftware.co.in/wp-content/uploads/TE-User-Guide.pdf

Overview presentation in open office format:
http://www.adhisoftware.co.in/wp-content/uploads/TE-Overview.odp

Training Videos:
http://www.youtube.com/watch?v=BptCOCWgivY
http://www.youtube.com/watch?v=afdVgCj-TUc
http://www.youtube.com/watch?v=cTZ2FCqgdwQ

Replies (44)

RE: Time & Expense 1.6 - Added by Adam Kuczma about 4 years ago

Hello,

I'm having two issues with your Time & Expense plugin:

1. It's said in manual that "The project member with “Log spent time” permission can create time & expense sheet." but when I set up "Log spent time" permission for user, the Time & Expense tab disappears for him. Is it good behavior?

2. On timesheet when I have two or more positions with the same project, blank issue but different custom field, export to pdf merges them into one position with summed hours.

Can you please tell me if these are problems only with my installation or general bugs that needs to be repaired.

Regards
Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

Adam,
1) did you give the View Spent Time permission ? only then they will see the Time & Expense menu item at the top.
2) On the pdf, we don't show the custom fields, so the timesheet rows get merged, thats the correct behaviour.

thanks

Dhanasingh

RE: Time & Expense 1.6 - Added by Adam Kuczma about 4 years ago

Thanks for fast reply,

1. No I didn't because I don't want users to see each other spent hours when they click "Overall spent time" on project. So there is no possibility to see only own time logs?
2. OK I understand, but creating pdf or csv shows custom fields columns with default values and summed hours.

Regards
Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

1) This restriction was introduced in 1.6, we will allow members with 'log spent time' also in 1.7
2) I thought we don't show the custom fields at all on pdf and csv, we will take a look and get back to you

RE: Time & Expense 1.6 - Added by Kosuke Fudy about 4 years ago

hi Dhanasingh,

I defined public holidays in Time & Expense plugin version 1.6,
Then how will it affect the way I fill the timesheet?
'Cause when I attempt to new timesheet which contains a public holiday,
nothing different as if I didn't define it.

Dhanasingh Krishnapandian wrote:

We are happy to announce the release of Time & Expense plugin version 1.6
Please download it from http://www.redmine.org/plugins/wk-time

Features:
- Supports REST Api
- Separate Permission for Approving Time Logs
- Filter timesheets by groups
- Filter Issues assigned to me
- Configure Public Holidays
- Support for MS SQL Server
- User with View Spent time permission can only see the list page.
Bugs:
- wrap Settings object within Rails.configuration.to_prepare inside init.rb
- Show the message “no users in the selected project" in new time/expense sheet
- Expense report link does not shows up by default
- Allow 0 for time/expense entry

Resources:

User guide:
http://www.adhisoftware.co.in/wp-content/uploads/TE-User-Guide.pdf

Overview presentation in open office format:
http://www.adhisoftware.co.in/wp-content/uploads/TE-Overview.odp

Training Videos:
http://www.youtube.com/watch?v=BptCOCWgivY
http://www.youtube.com/watch?v=afdVgCj-TUc
http://www.youtube.com/watch?v=cTZ2FCqgdwQ

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

Kosuke,
The public holidays will be effective only with Min or Max hour restriction is in effect.
If you have set either the Min or Max hour per day restrictions, then it will skip the public holiday for the min / max check.

Let me know if you have any further questions.

thanks

Dhanasingh

RE: Time & Expense 1.6 - Added by Adam Kuczma about 4 years ago

Hello,

I have serious problem in permission management - if two users have manager role in one project, but in other project only second user has manager role, the first user can see timesheets of second user from other project, but first user isn't even member of that second project, so why can he see spent time on that project?

Regards,
Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

Adam,
A manager is only editing a timesheet on his member's behalf.
So whatever view (timesheet) a member would see, will be visible to the manager.

The idea was to let the manager edit if the member was on vacation/absence/sick and don't have access to a computer or the manager wants to overwrite the hours entered by the member.

Since the member-manager relationship comes from one of the projects and that project should be used in the timesheet, we show the whole timeshet (the member's view)

Dhanasingh

RE: Time & Expense 1.6 - Added by Adam Kuczma about 4 years ago

Hello Dhanasingh,

Thanks for all answers, but unfortunately I have another question/problem.
After weeks of testing and customizing, I found that adding rows in timesheet with the same Project (blank issue), but different custom fields, merges them into one row. This happens in a strange way - it merges days where only one row has filled hours, it doesn't merge days where every row has filled hours. It's hard to describe by words, so I've prepared a diagram - see attachment.
My schedule is to run system in production environment from 1st November, so please tell me if problem is on my side only or global. How can I repair it?

Regards,

Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

Adam,
The picture makes it clearer.
We will take a look

Dhanasingh

RE: Time & Expense 1.6 - Added by Adam Kuczma about 4 years ago

Hello,

do you have any news about the error I've reported?

Regards,
Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian about 4 years ago

I think it is going to take a month or two to work on this. we will let you know.

Dhanasingh

RE: Time & Expense 1.6 - Added by Frank Pfeift almost 4 years ago

Problem seems to be global. We've got the same Issue:
The Plugin merges the rows into one, when the rows got the same Project, Ticket and Activity. We lost information on the Commentfield. The filled hours are summed.
I think the commentfield is also a need for validation on a new Row.

Regards,
Frank

Adam Kuczma wrote:

Hello Dhanasingh,

Thanks for all answers, but unfortunately I have another question/problem.
After weeks of testing and customizing, I found that adding rows in timesheet with the same Project (blank issue), but different custom fields, merges them into one row. This happens in a strange way - it merges days where only one row has filled hours, it doesn't merge days where every row has filled hours. It's hard to describe by words, so I've prepared a diagram - see attachment.
My schedule is to run system in production environment from 1st November, so please tell me if problem is on my side only or global. How can I repair it?

Regards,

Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian almost 4 years ago

Frank,
yes, currently it does add up the hours if the project, issue and activity are same and retains only one comment.

If you want to have individual comments per time entry, please do not enter comments from row, use the detail time entry pop up, then you can have individual comments per time entry.

Dhanasingh

RE: Time & Expense 1.6 - Added by Michael Blaich almost 4 years ago

Hello,

first of all I want to thanks Dhanasingh for this great plugin.

But after using this plugin I got a problem with the default time logging on the ticket itself. If I use the the "Log Time" button to spent time for a ticket I get the the folling error in the apache2/error.log

NoMethodError (undefined method `l' for #<Object:0x00000006f7b948>):
lib/redmine/hook.rb:61:in `block (2 levels) in call_hook'
lib/redmine/hook.rb:61:in `each'
lib/redmine/hook.rb:61:in `block in call_hook'
lib/redmine/hook.rb:58:in `tap'
lib/redmine/hook.rb:58:in `call_hook'
lib/redmine/hook.rb:153:in `call_hook'
app/controllers/timelog_controller.rb:124:in `create'

But time logging with the wktimes plugin will still work. After removing the wktimes plugin default time logging will work again.

I use Redmine 2.3.1 and Time & Expense 1.6.

Any help to this problem will be greate because we want to use this great plugin and the default time logging.

Regards,

Michael

RE: Time & Expense 1.6 - Added by Ivan Rapekas almost 4 years ago

Hi, Michael
Could you please run a command:

ruby script/about

and attach a part of production.log (if exists) beginning from 'Starting GET "/... bla-bla"'?

I am not sure, but it seems that I run into the similar problem. I don't remember exactly but the cause was in two plugins that were in conflict. I determined the 'bad' plugin and it was not a wktime. Also it was redmine 2.3.2 then upgraded to 2.4.0 and after that to 2.4.2.

I tried a lot of plugins. Now I realize that these plugins can work together. May be this list will be helpful to somebody.

Ivan

RE: Time & Expense 1.6 - Added by Adam Kuczma almost 4 years ago

Hello Dhanasingh,

sorry to bother you again, but I have another problem with your plugin.
I'm trying to enable email notification while timesheet is beeing rejected, but I get 'An error occurred while sending mail (uninitialized constant WktimeController::WkMailer)' error. Redmine is sending other emails without problems, but plugin doesn't. Let me know how can I repair it.

Regards,

Adam

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian almost 4 years ago

Adam,
Can you check the production log and see if there any details related to this problem.
Try going to the plugin configuration page and click 'Apply' once

This might be a plugin conflict issue as well, see if wktime is in conflict with some other plugin.

Dhanasingh

RE: Time & Expense 1.6 - Added by Adam Kuczma almost 4 years ago

Hi,
thanks for response. Unfortunately there are no errors in production.log, Applying configuration didn't help. Wktime is the only plugin I'm using. Is e-mail function working for you?
I'm on version:
Redmine version 2.3.2.stable
Ruby version 1.9.3-p194 (2012-04-20) [x86_64-linux]
Rails version 3.2.13
redmine_wktime 1.6

"Uninitialized constant WktimeController::WkMailer" error tells me nothing, because I'm not ruby programmer. Tried to google it, but no success.
I'll try to prepare new clean environment and test it again.

Regards,

Adam

RE: Time & Expense 1.6 - Added by Tomas Hubik almost 4 years ago

Hi,

is the 1.6 version of the plugin compatible with Redmine 2.4.x?

Thanks

Best regards
Tomas

RE: Time & Expense 1.6 - Added by Dhanasingh Krishnapandian almost 4 years ago

No 1.6 has not been tested with Redmine 2.4.x
it is been tested with Redmine 2.3.x

Dhanasingh

RE: Time & Expense 1.6 - Added by Darth Vader over 3 years ago

Hi,

I don't know exactly how to send features/bug requests as there is no github repository for this plugin. So I will use this conversation. If there is a better way, let me know.
Bug:
  1. When editing a time sheet most actions other than adding a row and entering time will discard your edits. For example, clicking the "Issues created by or assigned to the user" or selecting a certain issue tracker will discard all changes made to that point and revert to the last saved version of the time sheet.
  2. When selecting to print PDF, the printed PDF is the last saved version not the current version being edited. To properly print the current version, you have to save, which brings you back to the list, then select edit, then print the PDF (same with the csv output).
  3. Issues order gets mixed up after filtering by tracker: I create a new row, I select a tracker to filter by, issues order is mixed up: . It looks like an endianness issue as the issues are numbered in a power of two.
  4. The PDF printout does not have the issue tracker and number printed out.
Feature Request:
  1. When pressing the "Save" button, stay on the time sheet edit screen and don't go back to the issues list.
  2. If the save button stays on the edit screen, there should be a button to go back to the time sheet list or "save & exit" button.
  3. Issue selection should behave like the "Parent Task" button that allows entering the issue ID or search the title instead of being a drop down with all the issues listed.
  4. Nice to have: be able to select any of the custom filters defined by the user to filter the issues instead of just "assigned and created" and tracker type. For example, we have installed the involvement filter and it would be a nice one to use to filter issues.

Alexis

IssuesOrder.png (8.72 KB)

RE: Time & Expense 1.6 - Added by Tomas Hubik over 3 years ago

Hello,

I have some issues with upgrade from version 1.5 to 1.6. I can log in as admin, but logging in as other user gives me error 500. This user has not any time entry yet btw. Not I am using Redmine 2.4.3, which is not tested, ut this problem is not related to it as I had the same problem with version 2.2.

My log:
@
Started GET "/" for 12.34.56.78 at 2014-03-07 09:12:47 +0100
Processing by WelcomeController#index as HTML
Current user: xxxx.yyyy(id=7)
Rendered welcome/index.html.erb within layouts/base (10.6ms)
Rendered plugins/redmine_code_review/app/views/code_review/_html_header.html.erb (0.0ms)
Rendered plugins/redmine_improved_searchbox/app/views/redmine_improved_searchbox/_redmine_improved_searchbox_partial.html.erb (1.4ms)
Rendered plugins/clipboard_image_paste/app/views/clipboard_image_paste/_headers.html.erb (1.4ms)
Completed 500 Internal Server Error in 48.9ms

ActionView::Template::Error (Mysql2::Error: Unknown column 'time_entries.user_id' in 'where clause': SELECT `projects`.* FROM `projects` WHERE (((projects.status <> 9 AND projects.id IN (SELECT em.project_id FROM enabled_modules em WHERE em.name='time_tracking')) AND (projects.id IN (6,4,26,20,28) AND time_entries.user_id = 7)))):
22: <div id="top-menu">
23: <div id="account">
24: <%= render_menu :account_menu ->
25: </div>
26: <
= content_tag('div', "#{l(:label_logged_as)} #{link_to_user(User.current, :format => :username)}".html_safe, :id => 'loggedas') if User.current.logged? >
27: <
= render_menu :top_menu if User.current.logged? || !Setting.login_required? -%>
28: </div>
app/models/project.rb:286:in `find'
lib/redmine/menu_manager.rb:199:in `call'
lib/redmine/menu_manager.rb:199:in `allowed_node?'
lib/redmine/menu_manager.rb:166:in `block in menu_items_for'
lib/redmine/menu_manager.rb:165:in `each'
lib/redmine/menu_manager.rb:165:in `menu_items_for'
lib/redmine/menu_manager.rb:90:in `render_menu'
app/views/layouts/base.html.erb:25:in `_app_views_layouts_base_html_erb___3927296242324675982_39508900'
@

Could you, please, help?

Thanks.

TH

RE: Time & Expense 1.6 - Added by Darth Vader over 3 years ago

Tomas, I don't know if it's the same error as us but if it is a new user that hasn't entered a time sheet before, you have to deselect "Previous Week's Template" when creating a new time sheet as there is none.

RE: Time & Expense 1.6 - Added by Tomas Hubik over 3 years ago

Hello, thanks for tip, but this is not the problem. The usercan not even log into Redmine. Gets error 500 after entering username and password.

1 2 (1-25/44)