Project

General

Profile

Actions
Copy link

Defect #10130

closed

Broken italic text style in edited comment preview

Added by Etienne Massip about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Text formatting
Target version:
1.3.1
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
1.3.0

Description

r7932 breaks the edited comment preview style, text is no more in Italic.

Actions
Copy link
 #1

Updated by Etienne Massip about 11 years ago

  • Status changed from New to Confirmed
  • Target version changed from 1.4.0 to 1.3.1
  • Affected version (unused) changed from devel to 1.3.0
  • Affected version set to 1.3.0
Actions
Copy link
 #2

Updated by Jean-Philippe Lang about 11 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed and merged.

Actions
Copy link
 #3

Updated by Etienne Massip about 11 years ago

  • Status changed from Closed to Reopened

I thought I would have fixed it simply by moving the preview div in source:/trunk/app/views/journals/_notes_form.html.erb after the form, but because my dev env has been blocked for hours by a @#! long git fetch process and I couldn't test this fix.

Don't you think it would be a clean move? Issue update form preview div is not in the form and it make more sense to me since it does not contain any input control...

Actions
Copy link
 #4

Updated by Jean-Philippe Lang about 11 years ago

  • Status changed from Reopened to Closed

The div can not be moved out of form without adding some div and changing some javascript (try to edit and cancel). I won't do it in the stable branch so I reverted the change. I've added a specific css class in trunk (r8754) to target the form tips more accurately.

Actions
Copy link

Also available in: Atom PDF