Defect #10535
Atom feeds for the Project Activity contain incorrect hostname
Status: | Reopened | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Feeds | |||
Target version: | - | |||
Resolution: | Fixed | Affected version: | 1.3.0 |
Description
The link in the Atom feed (at least for Project Activity) contains a hostname detected by Rails, but not the one specified in settings.
This makes link unusable if the requests to Rails are proxified.
Versions:
Redmine:
SVN: http://redmine.rubyforge.org/svn/branches/1.3-stable revision 9240
Env:
Ruby version 1.8.7 (x86_64-linux) RubyGems version 1.3.7 Rack version 1.1.2 Rails version 2.3.14 Active Record version 2.3.14 Active Resource version 2.3.14 Action Mailer version 2.3.14 Active Support version 2.3.14 Application root /opt/redmine Environment production Database adapter mysql Database schema version 20110902000000
Related issues
Associated revisions
URLs in atom feeds don't take into account Setting.protocol and Setting.hostname (#10535).
Patch by Go MAEDA.
History
#1
Updated by Go MAEDA over 2 years ago
- File fix-10535-without-test.patch
added
- Status changed from New to Confirmed
Confirmed the issue. I think the links in the Atom feed should respect Setting.protocol
and Setting.host_name
.
The attached is a workaround for the issue.
#2
Updated by Go MAEDA over 2 years ago
- File test-10535.patch
added
- Target version set to Candidate for next major release
Updated tests.
#3
Updated by Go MAEDA over 2 years ago
- Target version changed from Candidate for next major release to 4.2.0
Setting the target version to 4.2.0.
#4
Updated by Go MAEDA over 2 years ago
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch.
#5
Updated by Go MAEDA about 2 years ago
- Related to Defect #17309: RSS feed gives away localhost link added
#6
Updated by Go MAEDA about 2 years ago
- Status changed from Closed to Reopened
r19810 generates incorrect links if Redmine is deployed using sub-URI.
For example, if ENV['RAILS_RELATIVE_URL_ROOT']
is '/dir
' and Setting.host_name
is 'example.net/dir
', a link to an issue will be http://example.net/dir/dir/issues/1
('dir
' appears twice).
#7
Updated by Go MAEDA about 2 years ago
Go MAEDA wrote:
r19810 generates incorrect links if Redmine is deployed using sub-URI.
For example, if
ENV['RAILS_RELATIVE_URL_ROOT']
is '/dir
' andSetting.host_name
is 'example.net/dir
', a link to an issue will behttp://example.net/dir/dir/issues/1
('dir
' appears twice).
And also app/views/journals/index.builder
should have been changed to support Setting.host_name
but r19810 didn't.
I will revert the change.
#8
Updated by Go MAEDA about 2 years ago
- Target version deleted (
4.2.0)