Patch #11057

Confirm admin flag change on a separate page

Added by Alex Shulgin over 10 years ago. Updated over 10 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Administration
Target version:-

Description

Having admin flag on the general tab in user's profile makes it
way too easy to flip the flag accidentally.

Attached patch adds a separate page to flip the flag.

0001-Confirm-admin-flag-change-on-a-separate-page.patch Magnifier (5.61 KB) Alex Shulgin, 2012-05-30 16:44

0001-Confirm-admin-flag-change-on-a-separate-tab.patch Magnifier (3.97 KB) Alex Shulgin, 2012-06-22 22:57

History

#1 Updated by Jean-Philippe Lang over 10 years ago

It's a bit overkill IMO. Why not adding a simple javascript confirmation message when changing the checkbox state?

#2 Updated by Etienne Massip over 10 years ago

Why not simply move it in its own "Administrator" fieldset?

Not sure it should remain in "Information" anyway, this is a security related concept, not a general information?

#3 Updated by Alex Shulgin over 10 years ago

Jean-Philippe Lang wrote:

It's a bit overkill IMO. Why not adding a simple javascript confirmation message when changing the checkbox state?

I disagree: a simple Yes/No popup is too easy to overlook or accept accidentally.

Etienne Massip wrote:

Why not simply move it in its own "Administrator" fieldset?

Not sure it should remain in "Information" anyway, this is a security related concept, not a general information?

Well, maybe that's a way to go. Want me to produce an adjusted patch with a separate tab?

#4 Updated by Alex Shulgin over 10 years ago

Alex Shulgin wrote:

Etienne Massip wrote:

Why not simply move it in its own "Administrator" fieldset?

Not sure it should remain in "Information" anyway, this is a security related concept, not a general information?

Well, maybe that's a way to go. Want me to produce an adjusted patch with a separate tab?

Attached is a reworked version with the admin tab instead of a separate page.

Also available in: Atom PDF