Redmine

sorry, forgot to mention, I'm referring to 2.0.1 code.

Git uses SHA-1 hash for revisions.
But, Redmine does not store Subversion UUID.
And Mercurial revision number changes among repositories.
So, changing repository path is very danger.

well this is not impacting the scm content actually that's only the destination of the configuration edit form that is changed to Jack Zheng. The @path could not be used for that.

And this patch don't make the repository path modificable.

What is a problem?
"repository_path" is Rails route syntax.

yes and it takes an argument which is the respository id, provided by Jack Zheng, but not by @path. Just try to edit a repository and it will say that route don't exist because @path is just not set for the edit view by the controller.

I cannot reproduce route error.
Please describe more details.

I have a project with an existing repository, I go to "settings', then 'repositories' tab, I see my git repo on one line, I click the link 'edit' on the right, and it gives me an error:

ActionController::RoutingError (No route matches {:action=>"update", :controller=>"repositories", :id=>nil}): 
    app/views/repositories/edit.html.erb:3:in `_app_views_repositories_edit_html_erb__1031469684_104936220'

:id being null, I go to the controller, see that Jack Zheng and Herve Harster are set by a before_filter on the edit method, then check the view, and see @path as an argument to repository_path(), so I change it to Jack Zheng, then it sets the id, and fixes the route.

I cannot reproduce on "ruby 1.8.7 (2012-02-08 patchlevel 358) [i686-linux]" and "passenger (3.0.11)".