Project

General

Profile

Actions

Patch #11534

closed

rake redmine:plugins:test:* could use "pattern" instead of "test_files"

Added by Jean-Baptiste Barth over 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Low
Category:
Plugin API
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

It's a lot less verbose so it's more readable when running plugin tests, and it's more similar to what's done in rails core.

So in lib/tasks/redmine.rake, we would replace:

t.test_files = FileList["plugins/#{ENV['NAME'] || '*'}/test/unit/*_test.rb"]
with
t.pattern = "plugins/#{ENV['NAME'] || '*'}/test/unit/*_test.rb" 
and so on.

Let me know if there's any objection, if not I'll commit that in a few days.

Actions #1

Updated by Jean-Baptiste Barth over 11 years ago

  • Status changed from New to Resolved
  • Target version set to Candidate for next major release

Committed in r10778, I let Jean-Philippe, Etienne or Toshi merge it in a stable branch when they want.

Actions #2

Updated by Jean-Baptiste Barth almost 11 years ago

  • Status changed from Resolved to Closed
  • Target version deleted (Candidate for next major release)

Closing this one, I didn't see it was present in 2.3-stable. I remove the target version, since 2.3.0 is closed and this patch isn't that important to be mentionned in 2.3.2.

Actions

Also available in: Atom PDF