Defect #13630
PDF export generates the issue id twice
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | PDF export | |||
| Target version: | 2.3.1 | |||
| Resolution: | Fixed | Affected version: | 2.3.0 |
Description
The pdf export generates the issue id twice:
I added a patch that fixes this bug.
double_issueID.png - PDF screenshot (10.7 KB)
pdf.rb.patch 
(2.09 KB)
pdf.rb.2.patch
(6.04 KB)
pdf.rb.3.patch
- .inject(0, :+)
(6.05 KB)
Related issues
Associated revisions
Fixed that issue list PDF export displays ID column twice (#13630).
Contributed by F Schroedter.
Code cleanup (#13630).
Contributed by F Schroedter.
History
#1
Updated by Etienne Massip almost 6 years ago
- Status changed from New to Confirmed
- Target version set to 2.3.1
Regression.
Not sure the patch is complete?
#2
Updated by F Schroedter almost 6 years ago
- File pdf.rb.2.patch added
This patch should be complete now. It also includes some code improvements: .inject(0) {|s,v| s += v} is replaced by .inject(:+)
#3
Updated by Etienne Massip almost 6 years ago
F Schroedter wrote:
This patch should be complete now. It also includes some code improvements:
.inject(0) {|s,v| s += v}is replaced by.inject(:+)
Looks fine. What Ruby version did you test it with, please?
#4
Updated by F Schroedter almost 6 years ago
Tested on ruby 1.9.2 and 1.9.3. The code improvement should also work on 1.8.7: http://stackoverflow.com/questions/1538789/how-to-sum-array-members-in-ruby
#5
Updated by Etienne Massip almost 6 years ago
Looks like .inject(0) {|s,w| s += w} should be replaced by .inject(0, :+) rather than .inject(:+)?
#7
Updated by Etienne Massip almost 6 years ago
- Status changed from Confirmed to Resolved
- Resolution set to Fixed
Fixed with r11693.
#8
Updated by Etienne Massip almost 6 years ago
- Status changed from Resolved to Closed
Merged from trunk.