Defect #14178

PDF API broken in version 2.3.1

Added by Massimo Rossello over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:PDF export
Target version:2.3.2
Resolution:Fixed Affected version:2.3.1

Description

The change in number of arguments in issues_to_pdf_draw_borders() in file lib/redmine/export/pdf.rb introduced by #13630 (r11693) breaks some plugins (namely redmine_wktime).

Would it be possible to restore the same arguments, even if id_width argument not used, for API compatibility?

Thanks

pdf.rb.patch Magnifier (1.4 KB) Massimo Rossello, 2013-05-30 18:01

Related issues

Follows Redmine - Defect #13630: PDF export generates the issue id twice Closed

Associated revisions

Revision 11920
Added by Toshi MARUYAMA over 7 years ago

pdf: restore "id_width" parameter of issues_to_pdf_draw_borders (#14178)

Contributed by Massimo Rossello.

Revision 11921
Added by Toshi MARUYAMA over 7 years ago

pdf: replace "id_width" parameter name to original "col_id_width" (#14178)

Revision 11924
Added by Toshi MARUYAMA over 7 years ago

Merged r11920 and r11921 from trunk to 2.3-stable (#14178)

pdf: restore "col_id_width" parameter of issues_to_pdf_draw_borders.

Contributed by Massimo Rossello.

History

#1 Updated by Massimo Rossello over 7 years ago

Here is a patch.
Sorry I can't change the tracker to patch

#2 Updated by Toshi MARUYAMA over 7 years ago

  • Target version set to 2.3.2

#3 Updated by Jan Niggemann (redmine.org team member) over 7 years ago

  • Tracker changed from Defect to Patch

Thank you for providing the patch!

#4 Updated by Toshi MARUYAMA over 7 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from PDF API broken to PDF API broken in version 2.3.1
  • Status changed from New to Closed
  • Affected version (unused) set to 2.3.1
  • Resolution set to Fixed
  • Affected version set to 2.3.1

Committed in trunk and 2.3-stable, thanks.

Also available in: Atom PDF