Project

General

Profile

Actions

Defect #13888

closed

Daylight savings causes inconsistency of Message-Id in emails

Added by pasquale [:dedalus] about 10 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

This to maintained threaded messages that are referred to same bug but are posted before and after daylight savings off\on

For me this is urgent because messed up my threaded bug mail.

xref bug #13851


Files

bug13851.patch (969 Bytes) bug13851.patch xref bug #13851 pasquale [:dedalus], 2013-04-26 08:41
fix-13888.diff (1.1 KB) fix-13888.diff Go MAEDA, 2019-02-18 15:30

Related issues

Has duplicate Redmine - Defect #13851: Unthreade new mail messageClosed

Actions
Actions #1

Updated by IFPE JAB almost 6 years ago

pasquale [:dedalus] wrote:

This to maintained threaded messages that are referred to same bug but are posted before and after daylight savings off\on

For me this is urgent because messed up my threaded bug mail.

xref bug #13851

nice job!

Actions #2

Updated by Toshi MARUYAMA almost 6 years ago

  • Priority changed from Urgent to Normal
Actions #3

Updated by Go MAEDA over 4 years ago

  • Target version set to Candidate for next major release

We don't have to care about daylight savings if we always use UTC when generating a message-id.

Index: app/models/mailer.rb
===================================================================
--- app/models/mailer.rb    (リビジョン 17870)
+++ app/models/mailer.rb    (作業コピー)
@@ -721,7 +721,7 @@
     hash = [
       "redmine",
       "#{object.class.name.demodulize.underscore}-#{object.id}",
-      timestamp.strftime("%Y%m%d%H%M%S")
+      timestamp.utc.strftime("%Y%m%d%H%M%S")
     ]
     if rand
       hash << Redmine::Utils.random_hex(8)
Actions #4

Updated by pasquale [:dedalus] over 4 years ago

Go MAEDA wrote:

We don't have to care about daylight savings if we always use UTC when generating a message-id.

[...]

yep, I agree

Actions #5

Updated by Go MAEDA over 4 years ago

  • File fix-13888.diff fix-13888.diff added
  • Tracker changed from Patch to Defect
  • Subject changed from Fix message-id mail header to be invariant respect daylight savings to Daylight savings causes inconsistency of Message-Id in emails
  • Target version changed from Candidate for next major release to 4.1.0

Attaching a patch that includes a test.

Actions #6

Updated by Go MAEDA over 4 years ago

  • Category changed from Email receiving to Email notifications
Actions #7

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed the fix.
The timestamp is UTC after r17890. Daylight savings will never affect message-id.

Actions #8

Updated by Go MAEDA over 4 years ago

  • Assignee set to Go MAEDA
Actions #9

Updated by Go MAEDA over 4 years ago

Actions #10

Updated by Go MAEDA over 4 years ago

Actions

Also available in: Atom PDF