Project

General

Profile

Actions

Defect #14737

closed

Gantt, completed % truncated instead of rounded

Defect #14737: Gantt, completed % truncated instead of rounded

Added by Jérôme BATAILLE over 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Gantt
Target version:
Resolution:
Fixed
Affected version:

Files

RM_14737_gantt_completed_pourcent_truncated.diff (834 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff Jérôme BATAILLE, 2013-08-21 16:23
RM_14737_gantt_completed_pourcent_truncated.diff (778 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff Jérôme BATAILLE, 2013-08-22 15:29
edit.png (6 KB) edit.png Toshi MARUYAMA, 2014-05-14 13:45
view.png (5.79 KB) view.png Toshi MARUYAMA, 2014-05-14 13:45

Related issues 1 (0 open — 1 closed)

Has duplicate Redmine - Feature #13442: Gantt : rounding error for version completed percentClosedActions

Updated by Daniel Felix about 13 years ago Actions #2

+1 to the patch.
But English comments would be better. ;-)

Updated by Daniel Felix about 13 years ago Actions #4

Np. Looks better. :-)

Updated by Jérôme BATAILLE over 12 years ago Actions #5

Any chance that this very simple patch could be integrated to the core ?

Updated by Toshi MARUYAMA over 12 years ago Actions #6

This problem is not only pdf but also web form.

diff --git a/app/views/issues/_attributes.html.erb b/app/views/issues/_attributes.html.erb
--- a/app/views/issues/_attributes.html.erb
+++ b/app/views/issues/_attributes.html.erb
@@ -63,7 +63,7 @@
 <% end %>

 <% if @issue.safe_attribute? 'estimated_hours' %>
-<p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
+<p><%= f.text_field :estimated_hours, :size => 10, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
 <% end %>

 <% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>


Updated by Jérôme BATAILLE over 12 years ago Actions #7

Hi Toshi,

You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.

Updated by Jérôme BATAILLE over 12 years ago Actions #8

Duplicated by #13442

Updated by Toshi MARUYAMA over 12 years ago Actions #9

Jérôme BATAILLE wrote:

Hi Toshi,

You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.

Sorry, I confused with #12510#note-15.

Updated by Toshi MARUYAMA over 12 years ago Actions #10

  • Target version set to 2.5.2

Updated by Toshi MARUYAMA over 12 years ago Actions #11

  • Target version changed from 2.5.2 to 2.6.0

Updated by Toshi MARUYAMA over 12 years ago Actions #12

  • Related to Feature #13442: Gantt : rounding error for version completed percent added

Updated by Toshi MARUYAMA over 12 years ago Actions #13

  • Related to deleted (Feature #13442: Gantt : rounding error for version completed percent)

Updated by Toshi MARUYAMA over 12 years ago Actions #14

  • Has duplicate Feature #13442: Gantt : rounding error for version completed percent added

Updated by Toshi MARUYAMA over 12 years ago Actions #15

It is reasonable because issue form uses round.
source:tags/2.5.1/app/helpers/application_helper.rb#L1122

Updated by Toshi MARUYAMA over 12 years ago Actions #16

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in trunk r13137, thanks.

Updated by Jérôme BATAILLE over 12 years ago Actions #17

Thanks a lot ! this is Smile 13'th patch integrated into the core.

Actions

Also available in: PDF Atom