Fix shadowing variable in ApplicationHelper#textilizable
fix using two different objects with same name, may cause problems
Updated by Ilya S about 10 years ago
yes, it isn't in this case, but may cause, because you create two different objects in same scope. Do you really think that's ok? Why do you rely on assumption that this piece of code will interprete right, instead of write it right?
and one more thing: code like this really hard to read, and maintain.
Updated by Go MAEDA about 1 year ago
- Subject changed from Fix shadowing variable to Fix shadowing variable in ApplicationHelper#textilizable
- Category changed from Text formatting to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version set to 5.1.0
- Resolution set to Fixed
Committed the fix. Thank you.