Project

General

Profile

Actions

Defect #16708

closed

Form is submitted when switching tab

Added by Nicolas Rodriguez almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

In render_tabs method, when I click on next tab or previous tab button, form is submit instead of switching tab.

I think you should change

  <div class="tabs-buttons" style="display:none;">
    <button class="tab-left" onclick="moveTabLeft(this);"></button>
    <button class="tab-right" onclick="moveTabRight(this);"></button>
  </div>

to

  <div class="tabs-buttons" style="display:none;">
    <button class="tab-left" onclick="moveTabLeft(this); return false;"></button>
    <button class="tab-right" onclick="moveTabRight(this); return false;"></button>
  </div>
Actions #1

Updated by Jean-Philippe Lang almost 10 years ago

  • Target version set to 2.5.2
Actions #2

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fix committed in r13108, thanks.

Actions #3

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions #4

Updated by Jean-Philippe Lang over 9 years ago

  • Subject changed from Form is submit when swithing tab to Form is submitted when swithing tab
Actions #5

Updated by Toshi MARUYAMA over 9 years ago

  • Subject changed from Form is submitted when swithing tab to Form is submitted when switching tab
Actions

Also available in: Atom PDF