Project

General

Profile

Actions

Patch #18047

closed

MailHandler: Don't use String#respond_to?(:force_encoding) to differentiate between Ruby 1.8 and Ruby 1.9

Added by Felix Schäfer over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email receiving
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In source:/trunk/app/models/mail_handler.rb@13413#L424, whether String#force_encoding is defined is used to make a decision about Mail::RubyVer, which defines pick_encoding on everything but Ruby 1.8.

This is dangerous as it couples knowledge about Ruby 1.8 (String#force_encoding is not defined) with knowledge about the Mail gem internals (Mail::RubyVer.pick_encoding is not defined on 1.8), there is no guarantee that this will always be the case though.

The attached patch checks whether Mail::RubyVer.pick_encoding is defined before using it instead of using the indirection through whether String#force_encoding is defined or not.


Files

check_for_pick_encoding.patch (573 Bytes) check_for_pick_encoding.patch Felix Schäfer, 2014-10-08 14:31

Related issues

Related to Redmine - Patch #15785: Support more character encodings in incoming emailsClosed

Actions
Actions #1

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Patch #15785: Support more character encodings in incoming emails added
Actions #2

Updated by Toshi MARUYAMA over 9 years ago

  • Category set to Email receiving
  • Target version set to 2.6.0
Actions #3

Updated by Toshi MARUYAMA over 9 years ago

  • Subject changed from Don't use String#respond_to?(:force_encoding) to differentiate between Ruby 1.8 and Ruby 1.9 to MailHandler: Don't use String#respond_to?(:force_encoding) to differentiate between Ruby 1.8 and Ruby 1.9
Actions #4

Updated by Toshi MARUYAMA over 9 years ago

  • Status changed from New to Closed

Committed in trunk r13432, thanks.

Rails 4 dropped Ruby 1.8 support.
So, Rails 4 branch r13255 removed this check.

Actions #5

Updated by Felix Schäfer over 9 years ago

Great, thanks!

Actions

Also available in: Atom PDF