Patch #20508
Required file lib/redmine/hook.rb is patching autoloaded ApplicationHelper
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 3.2.0 |
Description
Redmine::Hook::Helper is in file, which is required, but is patching ApplicationHelper and that is loaded by Rails autoloading. So its patch is forgotten after reloading
hook_availability_after_reload.patch 
(571 Bytes)
Associated revisions
Required file lib/redmine/hook.rb is patching autoloaded ApplicationHelper (#20508).
Patch by Ondřej.
Include helper instead of patching (#20508).
Extract classes to their own files to prevent loading issues (#20508).
History
#1
Updated by Jean-Philippe Lang about 6 years ago
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version set to 3.2.0
Patch committed in r14510, thanks.
#2
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from Closed to Reopened
Tests broken, patch reverted:
http://www.redmine.org/builds/logs/build_trunk_postgresql_ruby-2.2_2567.html
#3
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from Reopened to Closed
Different fix applied in r14693.